Skip to content

Check for USE_TLS=0 #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakirkham opened this issue Sep 18, 2018 · 7 comments
Closed

Check for USE_TLS=0 #1766

jakirkham opened this issue Sep 18, 2018 · 7 comments

Comments

@jakirkham
Copy link
Contributor

Looks like the USE_TLS checks only verify that it is defined. Would it be possible to check that it is defined with a non-zero value?

@brada4
Copy link
Contributor

brada4 commented Sep 19, 2018

@martin-frbg i could take care of ths class of issues starting here, +/- equaling -DXXX=0 to -UXXX

@brada4
Copy link
Contributor

brada4 commented Sep 19, 2018

@jakirkham if you use make as opposed to cmake you can just comment out offending line from Makefile.rule, in cmake I think whole sections need to be patched out until corrected.

@martin-frbg
Copy link
Collaborator

cmake builds of 0.3.3 do compile the "old" non-TLS version of memory.c by default, it is only plain make builds that are affected by the unintended presetting of USE_TLS=1 in Makefile.rule.

@brada4
Copy link
Contributor

brada4 commented Sep 19, 2018

thus it is just to take one line away in Makefile.rule to get intended default?

@martin-frbg
Copy link
Collaborator

Updated PR #1765 just now to address both these issues.

@martin-frbg
Copy link
Collaborator

Merged #1765, so should be fixed on the develop branch.

@jakirkham
Copy link
Contributor Author

Great, thanks Martin. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants