Skip to content

Commit 2e3d9a2

Browse files
committed
fix(pat-inject): Fix problem with pat-autosubmit together with pat-sortable and/or pat-clone.
1 parent c56dbc2 commit 2e3d9a2

File tree

2 files changed

+21
-7
lines changed

2 files changed

+21
-7
lines changed

src/pat/auto-submit/auto-submit.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export default Base.extend({
4444
data?.pattern === "sortable"
4545
) {
4646
// Directly submit when removing a clone or changing the sorting.
47-
this.$el.submit();
47+
this.el.dispatchEvent(events.submit_event());
4848
log.debug(
4949
`triggered by pat-update, pattern: ${data.pattern}, action: ${data.action}`
5050
);

src/pat/auto-submit/auto-submit.test.js

Lines changed: 20 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,17 @@ describe("pat-autosubmit", function () {
134134
</form>
135135
`;
136136
const el = document.querySelector(".pat-autosubmit");
137-
const instance = new Pattern(el);
138-
const spy = jest.spyOn(instance.$el, "submit");
137+
138+
let submit_dispatched = false;
139+
el.addEventListener("submit", () => {
140+
submit_dispatched = true;
141+
});
142+
143+
new Pattern(el);
144+
139145
$(el).trigger("pat-update", { pattern: "clone", action: "removed" });
140-
expect(spy).toHaveBeenCalled();
146+
147+
expect(submit_dispatched).toBe(true);
141148
});
142149

143150
it("2.4 - when pat-sortable changes the sorting", function () {
@@ -146,10 +153,17 @@ describe("pat-autosubmit", function () {
146153
</form>
147154
`;
148155
const el = document.querySelector(".pat-autosubmit");
149-
const instance = new Pattern(el);
150-
const spy = jest.spyOn(instance.$el, "submit");
156+
157+
let submit_dispatched = false;
158+
el.addEventListener("submit", () => {
159+
submit_dispatched = true;
160+
});
161+
162+
new Pattern(el);
163+
151164
$(el).trigger("pat-update", { pattern: "sortable" });
152-
expect(spy).toHaveBeenCalled();
165+
166+
expect(submit_dispatched).toBe(true);
153167
});
154168
});
155169

0 commit comments

Comments
 (0)