Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 09cfff4

Browse files
committedMay 10, 2016
load-module.t: re-indent and add some comments.
No functional changes.
1 parent 5bad2b3 commit 09cfff4

File tree

1 file changed

+32
-22
lines changed

1 file changed

+32
-22
lines changed
 

‎ext/XS-APItest/t/load-module.t

Lines changed: 32 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
#!perl -w
22
use strict;
33

4+
# Test the load_module() core API function.
5+
#
6+
# Note that this function can be passed arbitrary and illegal module
7+
# names which would already have been caught if a require statement had
8+
# been compiled. So check that load_module() can catch such bad things.
9+
410
use Test::More;
511
use XS::APItest;
612

@@ -22,29 +28,33 @@ like($@, qr/less version 1 required--this is only version 0\./,
2228
is(eval { load_module(PERL_LOADMOD_NOIMPORT, 'less', 0.03); 1}, 1,
2329
"expect load_module() not to fail");
2430

31+
#
32+
# Check for illegal module names
33+
2534
for (["", qr!\ABareword in require maps to empty filename!],
26-
["::", qr!\ABareword in require must not start with a double-colon: "::"!],
27-
["::::", qr!\ABareword in require must not start with a double-colon: "::::"!],
28-
["::/", qr!\ABareword in require must not start with a double-colon: "::/!],
29-
["/", qr!\ABareword in require maps to disallowed filename "/\.pm"!],
30-
["::/WOOSH", qr!\ABareword in require must not start with a double-colon: "::/WOOSH!],
31-
[".WOOSH", qr!\ABareword in require maps to disallowed filename "\.WOOSH\.pm"!],
32-
["::.WOOSH", qr!\ABareword in require must not start with a double-colon: "::.WOOSH!],
33-
["WOOSH::.sock", qr!\ABareword in require contains "/\."!],
34-
["WOOSH::.sock", qr!\ABareword in require contains "/\."!],
35-
["WOOSH/.sock", qr!\ABareword in require contains "/\."!],
36-
["WOOSH/..sock", qr!\ABareword in require contains "/\."!],
37-
["WOOSH/../sock", qr!\ABareword in require contains "/\."!],
38-
["WOOSH::..::sock", qr!\ABareword in require contains "/\."!],
39-
["WOOSH::.::sock", qr!\ABareword in require contains "/\."!],
40-
["WOOSH::./sock", qr!\ABareword in require contains "/\."!],
41-
["WOOSH/./sock", qr!\ABareword in require contains "/\."!],
42-
["WOOSH/.::sock", qr!\ABareword in require contains "/\."!],
43-
["WOOSH/..::sock", qr!\ABareword in require contains "/\."!],
44-
["WOOSH::../sock", qr!\ABareword in require contains "/\."!],
45-
["WOOSH::../..::sock", qr!\ABareword in require contains "/\."!],
46-
["WOOSH\0sock", qr!\ACan't locate WOOSH\\0sock.pm:!],
47-
) {
35+
["::", qr!\ABareword in require must not start with a double-colon: "::"!],
36+
["::::", qr!\ABareword in require must not start with a double-colon: "::::"!],
37+
["::/", qr!\ABareword in require must not start with a double-colon: "::/!],
38+
["/", qr!\ABareword in require maps to disallowed filename "/\.pm"!],
39+
["::/WOOSH", qr!\ABareword in require must not start with a double-colon: "::/WOOSH!],
40+
[".WOOSH", qr!\ABareword in require maps to disallowed filename "\.WOOSH\.pm"!],
41+
["::.WOOSH", qr!\ABareword in require must not start with a double-colon: "::.WOOSH!],
42+
["WOOSH::.sock", qr!\ABareword in require contains "/\."!],
43+
["WOOSH::.sock", qr!\ABareword in require contains "/\."!],
44+
["WOOSH/.sock", qr!\ABareword in require contains "/\."!],
45+
["WOOSH/..sock", qr!\ABareword in require contains "/\."!],
46+
["WOOSH/../sock", qr!\ABareword in require contains "/\."!],
47+
["WOOSH::..::sock", qr!\ABareword in require contains "/\."!],
48+
["WOOSH::.::sock", qr!\ABareword in require contains "/\."!],
49+
["WOOSH::./sock", qr!\ABareword in require contains "/\."!],
50+
["WOOSH/./sock", qr!\ABareword in require contains "/\."!],
51+
["WOOSH/.::sock", qr!\ABareword in require contains "/\."!],
52+
["WOOSH/..::sock", qr!\ABareword in require contains "/\."!],
53+
["WOOSH::../sock", qr!\ABareword in require contains "/\."!],
54+
["WOOSH::../..::sock", qr!\ABareword in require contains "/\."!],
55+
["WOOSH\0sock", qr!\ACan't locate WOOSH\\0sock.pm:!],
56+
)
57+
{
4858
my ($module, $error) = @$_;
4959
my $module2 = $module; # load_module mangles its first argument
5060
no warnings 'syscalls';

0 commit comments

Comments
 (0)
Please sign in to comment.