Skip to content

Commit 44b1835

Browse files
jimctonycoz
authored andcommitted
s/@results/@res_puts/ in process_puts
1 parent 32dfbb3 commit 44b1835

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

Porting/bench.pl

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -482,11 +482,11 @@ sub select_a_perl {
482482
}
483483

484484

485-
# Validate the list of perl=label on the command line.
486-
# Return a list of [ exe, label ] pairs.
485+
# Validate the list of perl=label (+ cmdline options) on the command line.
486+
# Return a list of [ exe, label, cmdline-options ] tuples, ie PUTs
487487

488488
sub process_puts {
489-
my @results;
489+
my @res_puts; # returned, each item is [ perlexe, label, @putargs ]
490490
my %seen;
491491
my @putargs; # collect not-perls into args per PUT
492492

@@ -499,13 +499,17 @@ sub process_puts {
499499

500500
my $r = qx($perl -e 'print qq(ok\n)' 2>&1);
501501
if ($r eq "ok\n") {
502-
push @results, [ $perl, $label, reverse @putargs ];
502+
push @res_puts, [ $perl, $label, reverse @putargs ];
503503
@putargs = ();
504+
warn "Added Perl-Under-Test: [ @{[@{$res_puts[-1]}]} ]\n"
505+
if $OPTS{verbose};
504506
} else {
507+
warn "putargs: @putargs + $p, a not-perl: $r\n"
508+
if $OPTS{verbose};
505509
push @putargs, $p; # not-perl
506510
}
507511
}
508-
return reverse @results;
512+
return reverse @res_puts;
509513
}
510514

511515

0 commit comments

Comments
 (0)