Skip to content

Commit 55bb620

Browse files
committed
Do not ignore non-zero error code from 'make minitest'
In pipelines like: $ sh ./Configure -des -Dusedevel && \ make minitest && make test_harness ... we don't want to run 'make test_harness' unless 'make minitest' has succeeded. To test: $ echo "exit(1);" >> t/base/cond.t $ make minitest && echo "hello world" # [note that minitest fails quickly and 'echo' is not reached] $ git checkout -- t/base/cond.t $ make minitest && echo "hello world" # [note that minitest runs and 'echo' is reached] For: #16160 Originally: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=132139
1 parent b6dbf1d commit 55bb620

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Makefile.SH

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1657,15 +1657,15 @@ minitest_prep:
16571657
@echo "You may see some irrelevant test failures if you have been unable"
16581658
@echo "to build lib/Config.pm, or the Unicode data files."
16591659
@echo " "
1660-
- cd t && (rm -f $(PERL_EXE); $(LNS) ../$(MINIPERL_EXE) $(PERL_EXE))
1660+
cd t && (rm -f $(PERL_EXE); $(LNS) ../$(MINIPERL_EXE) $(PERL_EXE))
16611661
16621662
MINITEST_TESTS = base/*.t comp/*.t cmd/*.t run/*.t io/*.t re/*.t opbasic/*.t op/*.t uni/*.t perf/*.t
16631663
16641664
minitest: $(MINIPERL_EXE) minitest_prep
1665-
- cd t && $(RUN_PERL) TEST $(MINITEST_TESTS) <$(devtty)
1665+
cd t && $(RUN_PERL) TEST $(MINITEST_TESTS) <$(devtty)
16661666
16671667
minitest-notty minitest_notty: $(MINIPERL_EXE) minitest_prep
1668-
- cd t && PERL_SKIP_TTY_TEST=1 $(RUN_PERL) TEST $(MINITEST_TESTS)
1668+
cd t && PERL_SKIP_TTY_TEST=1 $(RUN_PERL) TEST $(MINITEST_TESTS)
16691669
16701670
# Test via harness
16711671

0 commit comments

Comments
 (0)