Skip to content

Commit d28a925

Browse files
author
Father Chrysostomos
committed
Don’t call save_re_context
It is an empty function.
1 parent b4fa55d commit d28a925

File tree

5 files changed

+4
-6
lines changed

5 files changed

+4
-6
lines changed

mg.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1759,7 +1759,6 @@ Perl_magic_methcall(pTHX_ SV *sv, const MAGIC *mg, SV *meth, U32 flags,
17591759
if (flags & G_WRITING_TO_STDERR) {
17601760
SAVETMPS;
17611761

1762-
save_re_context();
17631762
SAVESPTR(PL_stderrgv);
17641763
PL_stderrgv = NULL;
17651764
}

regcomp.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6054,7 +6054,6 @@ S_compile_runtime_code(pTHX_ RExC_state_t * const pRExC_state,
60546054

60556055
ENTER;
60566056
SAVETMPS;
6057-
save_re_context();
60586057
PUSHSTACKi(PERLSI_REQUIRE);
60596058
/* G_RE_REPARSING causes the toker to collapse \\ into \ when
60606059
* parsing qr''; normally only q'' does this. It also alters

sv.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14875,7 +14875,6 @@ Perl_sv_recode_to_utf8(pTHX_ SV *sv, SV *encoding)
1487514875
nsv = sv_newmortal();
1487614876
SvSetSV_nosteal(nsv, sv);
1487714877
}
14878-
save_re_context();
1487914878
PUSHMARK(sp);
1488014879
EXTEND(SP, 3);
1488114880
PUSHs(encoding);
@@ -14946,7 +14945,6 @@ Perl_sv_cat_decode(pTHX_ SV *dsv, SV *encoding,
1494614945
dSP;
1494714946
ENTER;
1494814947
SAVETMPS;
14949-
save_re_context();
1495014948
PUSHMARK(sp);
1495114949
EXTEND(SP, 6);
1495214950
PUSHs(encoding);

utf8.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2357,7 +2357,6 @@ Perl__core_swash_init(pTHX_ const char* pkg, const char* name, SV *listsv, I32 m
23572357
PUSHSTACKi(PERLSI_MAGIC);
23582358
ENTER;
23592359
SAVEHINTS();
2360-
save_re_context();
23612360
/* We might get here via a subroutine signature which uses a utf8
23622361
* parameter name, at which point PL_subname will have been set
23632362
* but not yet used. */
@@ -2371,6 +2370,10 @@ Perl__core_swash_init(pTHX_ const char* pkg, const char* name, SV *listsv, I32 m
23712370
GvSV(PL_errgv) = NULL;
23722371
/* It is assumed that callers of this routine are not passing in
23732372
* any user derived data. */
2373+
/* XXX The following comment is out of date. The
2374+
save_re_context() call used to be right after
2375+
SAVEHINTS() above, but no longer exists. Does the
2376+
errsv_save bit still apply? */
23742377
/* Need to do this after save_re_context() as it will set
23752378
* PL_tainted to 1 while saving $1 etc (see the code after getrx:
23762379
* in Perl_magic_get). Even line to create errsv_save can turn on

util.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1533,7 +1533,6 @@ S_invoke_exception_hook(pTHX_ SV *ex, bool warn)
15331533
SV *exarg;
15341534

15351535
ENTER;
1536-
save_re_context();
15371536
if (warn) {
15381537
SAVESPTR(*hook);
15391538
*hook = NULL;

0 commit comments

Comments
 (0)