Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit decf70b

Browse files
committedMay 16, 2016
POSIX: add lround() to the :math_h_c99 export tag
Closes RT#127821.
1 parent c04bead commit decf70b

File tree

3 files changed

+6
-11
lines changed

3 files changed

+6
-11
lines changed
 

‎ext/POSIX/lib/POSIX.pm

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -428,7 +428,7 @@ my %other_export_tags = ( # cf. exports policy below
428428
Inf NaN acosh asinh atanh cbrt copysign erf erfc exp2 expm1 fdim fma
429429
fmax fmin fpclassify hypot ilogb isfinite isgreater isgreaterequal
430430
isinf isless islessequal islessgreater isnan isnormal isunordered j0 j1
431-
jn lgamma log1p log2 logb lrint nan nearbyint nextafter nexttoward
431+
jn lgamma log1p log2 logb lrint lround nan nearbyint nextafter nexttoward
432432
remainder remquo rint round scalbn signbit tgamma trunc y0 y1 yn
433433
)],
434434

@@ -465,10 +465,7 @@ my %other_export_tags = ( # cf. exports policy below
465465

466466
# you do not want to add symbols to the following list. add a new tag instead
467467
our @EXPORT_OK = (qw(close lchown nice open pipe read sleep times write
468-
printf sprintf lround),
469-
# lround() should really be in the :math_h_c99 tag, but
470-
# we're too far into the 5.24 code freeze for that to be
471-
# done now. This can be revisited in the 5.25.x cycle.
468+
printf sprintf),
472469
grep {!exists $export{$_}} keys %reimpl, keys %replacement, keys %export_ok);
473470

474471
our %EXPORT_TAGS = ( %default_export_tags, %other_export_tags );

‎ext/POSIX/t/export.t

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -141,14 +141,17 @@ my %expect = (
141141
waitpid write
142142
),
143143
# this stuff was added in 5.21
144+
# (though an oversight meant that lround wasn't listed here
145+
# initially; it was added to @EXPORT_OK in 5.23, and to the
146+
# :math_h_c99 tag in 5.25)
144147
qw(
145148
FE_DOWNWARD FE_TONEAREST FE_TOWARDZERO FE_UPWARD
146149
fegetround fesetround
147150
Inf NaN
148151
acosh asinh atanh cbrt copysign erf erfc exp2 expm1 fdim
149152
fma fmax fmin fpclassify hypot ilogb isfinite isgreater
150153
isgreaterequal isinf isless islessequal islessgreater isnan
151-
isnormal isunordered j0 j1 jn lgamma log1p log2 logb lrint nan
154+
isnormal isunordered j0 j1 jn lgamma log1p log2 logb lrint lround nan
152155
nearbyint nextafter nexttoward remainder remquo rint round scalbn
153156
signbit tgamma trunc y0 y1 yn strtold
154157
),
@@ -166,10 +169,6 @@ my %expect = (
166169
POLL_IN POLL_OUT POLL_MSG POLL_ERR POLL_PRI POLL_HUP
167170
SI_USER SI_QUEUE SI_TIMER SI_ASYNCIO SI_MESGQ
168171
),
169-
# this was implemented in 5.21, but not exported; it was added to
170-
# @EXPORT_OK late in 5.23, and will be added to :math_h_c99 tag early
171-
# in 5.25
172-
qw( lround ),
173172
],
174173
);
175174

‎ext/POSIX/t/math.t

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ use strict;
44

55
use POSIX ':math_h_c99';
66
use POSIX ':nan_payload';
7-
use POSIX 'lround';
87
use Test::More;
98

109
use Config;

0 commit comments

Comments
 (0)
Please sign in to comment.