First "eof" should return true

haukex · tonycoz · commit eb699a9c8fb7 · 2019-01-02T11:53:51.000+11:00
When no file has previously been opened, "eof" should return true. This behavior was broken by 32e6532 (see also [#60978]).
diff --git a/pp_sys.c b/pp_sys.c
@@ -2121,7 +2121,7 @@ PP(pp_eof)
     }
 
     if (!gv)
-	RETPUSHNO;
+	RETPUSHYES;
 
     if ((io = GvIO(gv)) && (mg = SvTIED_mg((const SV *)io, PERL_MAGIC_tiedscalar))) {
 	return tied_method1(SV_CONST(EOF), SP, MUTABLE_SV(io), mg, newSVuv(which));
diff --git a/t/io/tell.t b/t/io/tell.t
@@ -189,7 +189,6 @@ seek *$fh,0,0;
 is(tell, 0, "argless tell after seek *\$coercible...");
 
 {
-    local $TODO = "not fixed yet";
     # [perl #133721]
     fresh_perl_is(<<'EOI', 'ok', {}, 'eof with no ${^LAST_FH}');
 print "ok" if eof;

Original file line number	Diff line number	Diff line change
`@@ -2121,7 +2121,7 @@ PP(pp_eof)`
`2121`	`2121`	`}`
`2122`	`2122`
`2123`	`2123`	`if (!gv)`
`2124`		`- RETPUSHNO;`
	`2124`	`+ RETPUSHYES;`
`2125`	`2125`
`2126`	`2126`	`if ((io = GvIO(gv)) && (mg = SvTIED_mg((const SV *)io, PERL_MAGIC_tiedscalar))) {`
`2127`	`2127`	`return tied_method1(SV_CONST(EOF), SP, MUTABLE_SV(io), mg, newSVuv(which));`
Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,6 @@ seek *$fh,0,0;`
`189`	`189`	`is(tell, 0, "argless tell after seek *\$coercible...");`
`190`	`190`
`191`	`191`	`{`
`192`		`- local $TODO = "not fixed yet";`
`193`	`192`	`# [perl #133721]`
`194`	`193`	`fresh_perl_is(<<'EOI', 'ok', {}, 'eof with no ${^LAST_FH}');`
`195`	`194`	`print "ok" if eof;`