Skip to content

Commit fbe0543

Browse files
author
Father Chrysostomos
committed
op.c:S_my_kid: Remove obsolete comment
/* XXX does this let anything illegal in? */ The commit that added that comment indeed allowed ‘our $$x’ and even ‘my $$x’, so it was a problem at the time. It was this commit: commit 77ca0c9 Author: Larry Wall <[email protected]> Date: Fri Sep 24 14:59:37 1999 -0700 Re: [PATCH 5.005_61] "our" declarations This commit fixed the problem: commit b6512f4 Author: Mark-Jason Dominus <[email protected]> Date: Mon Dec 24 13:14:48 2001 -0500 PATCH: Restore "Can't declare scalar dereference in my" error so the comment is no longer relevant.
1 parent 18d04e7 commit fbe0543

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

op.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3668,7 +3668,7 @@ S_my_kid(pTHX_ OP *o, OP *attrs, OP **imopsp)
36683668
return o;
36693669
} else if (type == OP_RV2SV || /* "our" declaration */
36703670
type == OP_RV2AV ||
3671-
type == OP_RV2HV) { /* XXX does this let anything illegal in? */
3671+
type == OP_RV2HV) {
36723672
if (cUNOPo->op_first->op_type != OP_GV) { /* MJD 20011224 */
36733673
S_cant_declare(aTHX_ o);
36743674
} else if (attrs) {

0 commit comments

Comments
 (0)