-
Notifications
You must be signed in to change notification settings - Fork 577
re/regexp.t failures on ubuntu 11.04 #11667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
From [email protected]Created by [email protected]I upgraded my ubuntu to 11.04 and started have compilation Failed 6 tests out of 2044, 99.71% okay. This is the same test failure: each regexp_*.t test calls regexp.t The tests pass with C<(cd t; ./perl harness re/*.t) but
$got = "T"; ; Before upgrading to ubuntu 11.04, I had no test failues, using gcc-4.6.0 I tried upgrading to gcc-4.6.1 but it would not compile. Perl Info
|
From @cpansproutOn Sun Sep 25 15:34:33 2011, rmbarker.cpan@btinternet.com wrote:
I believe this has just been fixed with this commit: If that is not the case, please holler and I will re-open the ticket.
PATH=/home/robin/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
|
The RT System itself - Status changed from 'new' to 'open' |
@cpansprout - Status changed from 'open' to 'resolved' |
From @nwc10On Sun, Sep 25, 2011 at 03:34:34PM -0700, Robin Barker wrote:
I can't work out what version this actually is. $ git show 9c8c35062b12e41237396ffd50b944586cbce3bf The above description looks suspiciously like the problem solved by commit 1b7228c regexp.t: print diagnostics with leading '#' Inline Patchdiff --git a/t/re/regexp.t b/t/re/regexp.t
index 9c430ad..815b877 100644
--- a/t/re/regexp.t
+++ b/t/re/regexp.t
@@ -59,6 +59,11 @@ BEGIN {
}
+sub _comment {
+ return map { /^#/ ? "$_\n" : "# $_\n" }
+ map { split /\n/ } @_;
+}
+
use strict;
use warnings FATAL=>"all";
use vars qw($iters $numtests $bang $ffff $nulnul $OP);
@@ -175,7 +180,7 @@ EOFCODE
next TEST;
}
elsif ($@) {
- print "not ok $test$todo $input => error `$err'\n$code\n$@\n"; next TEST;
+ print "not ok $test$todo $input => error `$err'\n", _comment("$code\n$@\n"); next TEST;
}
elsif ($result =~ /^n/) {
if ($match) { print "not ok $test$todo ($study) $input => false positive\n"; next TEST }
@@ -184,12 +189,12 @@ EOFCODE
if (!$match || $got ne $expect) {
eval { require Data::Dumper };
if ($@) {
- print "not ok $test$todo ($study) $input => `$got', match=$match\n$code\n";
+ print "not ok $test$todo ($study) $input => `$got', match=$match\n", _comment("$code\n");
}
else { # better diagnostics
my $s = Data::Dumper->new([$subject],['subject'])->Useqq(1)->Dump;
my $g = Data::Dumper->new([$got],['got'])->Useqq(1)->Dump;
- print "not ok $test$todo ($study) $input => `$got', match=$match\n$s\n$g\n$code\n";
+ print "not ok $test$todo ($study) $input => `$got', match=$match\n", _comment("$s\n$g\n$code\n");
}
next TEST;
}
Nicholas Clark |
Migrated from rt.perl.org#99972 (status was 'resolved')
Searchable as RT99972$
The text was updated successfully, but these errors were encountered: