Subject: non-info in git_commit_id_title='Commit id:' #13920
Comments
From @jimcCreated by @jimccurrently git_commit_id_title carries no info. Perl Info |
From @jimcOn Fri, Jun 13, 2014 at 8:48 AM, Jim Cromie <perlbug-followup@perl.org>
|
From @jimc0001-make_patchnum-add-HEAD-commit-info-to-commit_id_titl.patchFrom 7990f6a1e31d1c9c08ffba7dc57e9a8e83187ea2 Mon Sep 17 00:00:00 2001
From: Jim Cromie <[email protected]>
Date: Sat, 2 Nov 2013 12:56:46 -0600
Subject: [PATCH] make_patchnum: add HEAD commit info to commit_id_title
Currently, the value of "git_commit_id_title" in ./lib/Config_git.pl
carries no new info; though it says either 'Commit id:' or 'Derived
from:', thats already known via git_uncommitted_changes='0'.
This patch appends `git log --oneline -1` to git_commit_id_title's
current value.
BEFORE:
$ ./perl -Ilib -V:git.+
git_commit_id='1da5bb70ab48e3af769fcf1266b774a7dbe63a88';
git_describe='v5.20.0-RC1-9-g1da5bb7';
git_branch='blead';
git_uncommitted_changes='0';
git_commit_id_title='Commit id:';
git_commit_date='2014-05-24 14:25:14 +0100';
$ git rebase blead for-git-conf
First, rewinding head to replay your work on top of it...
Applying: make_patchnum: add HEAD commit info to commit_id_title
$ make -j4 > /dev/null 2>&1
AFTER:
$ ./perl -Ilib -V:git.+
git_commit_id='644fa81fabaf3c7afc0d6e7dbf0c3c61cf4e93f6';
git_describe='v5.20.0-RC1-10-g644fa81';
git_branch='for-git-conf';
git_uncommitted_changes='0';
git_commit_id_title='Commit id: 644fa81 make_patchnum: add HEAD commit info to commit_id_title';
git_commit_date='2014-05-24 10:24:46 -0600';
$ ./perl -Ilib -V:git.+
git_commit_id='952a411024b428d0f0f011ff3b4600cc5c42fb47';
git_describe='v5.20.0-RC1-7-g952a411';
git_branch='for-git-conf';
git_uncommitted_changes='0';
git_commit_id_title='Commit id: 952a411 make_patchnum: add HEAD commit info to commit_id_title';
git_commit_date='2014-05-22 08:36:28 -0600';
---
make_patchnum.pl | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/make_patchnum.pl b/make_patchnum.pl
index 3f857b5..f68dd46 100644
--- a/make_patchnum.pl
+++ b/make_patchnum.pl
@@ -172,10 +172,11 @@ git_remote_branch='$remote/$merge'
git_unpushed='$unpushed_commit_list'";
}
}
+ my $head = backtick("git log --oneline -1");
if ($changed) {
- $commit_title = "Derived from:";
+ $commit_title = "Derived from: $head";
}
- $commit_title ||= "Commit id:";
+ $commit_title ||= "Commit id: $head";
}
# we extract the filename out of the warning header, so don't mess with that
--
1.8.3.1
|
From @jkeenanOn Fri Jun 13 07:53:36 2014, yoduh wrote:
This patch looks plausible, but as I was completely unaware of the existence of the file to be patched, I would like to ask if the patch could be evaluated by someone who has previously worked on make_patchnum.pl? khw? Yves? From 7990f6a1e31d1c9c08ffba7dc57e9a8e83187ea2 Mon Sep 17 00:00:00 2001 Currently, the value of "git_commit_id_title" in ./lib/Config_git.pl BEFORE: $ git rebase blead for-git-conf AFTER: $ ./perl -Ilib -V:git.+ make_patchnum.pl | 5 +++-- Inline Patchdiff --git a/make_patchnum.pl b/make_patchnum.pl
index 3f857b5..f68dd46 100644
--- a/make_patchnum.pl
+++ b/make_patchnum.pl
@@ -172,10 +172,11 @@ git_remote_branch='$remote/$merge'
git_unpushed='$unpushed_commit_list'";
}
}
+ my $head = backtick("git log --oneline -1");
if ($changed) {
- $commit_title = "Derived from:";
+ $commit_title = "Derived from: $head";
}
- $commit_title ||= "Commit id:";
+ $commit_title ||= "Commit id: $head";
}
# we extract the filename out of the warning header, so don't mess with that
--
1.8.3.1 |
|
The RT System itself - Status changed from 'new' to 'open' |
From @tonycozOn Fri Jun 13 07:53:36 2014, yoduh wrote:
git_commit_id_title is replaced into myconfig.SH, and becomes part of the output of perl -V: Summary of my perl5 (revision 5 version 21 subversion 1) configuration: It's exactly what it says it is - the title for git_commit_id included in perl -V. I'll reject this patch in a few days unless someone points out I'm wrong. Tony |
From @jimcOn Mon, Jun 16, 2014 at 12:06 AM, Tony Cook via RT <
I see no title in there. only the whole sha1. Its clear from your -V output that the commit-id is there, commit cb52689 some perldelta fixes looking more closely at myconfig.SH, cat <<'!NO!SUBS!' but the title (1st line of the commit message) is not. otherwise it would say at least Frankly we dont need both commit-id and commit-id-title. So perhaps this patch is incomplete (missing tweaks to myconfig.SH), rather |
From @ikegamiOn Mon, Jun 16, 2014 at 3:30 PM, Jim Cromie <jim.cromie@gmail.com> wrote:
Not title of the commit, title (label) of the field. "Derived from" and |
From @tonycozOn Mon Jun 16 12:31:48 2014, yoduh wrote:
It's not the title of the commit itself, it's providing a label for the commit id to indicate whether the build is for that specific commit id or for that commit with some changes. git_commit_id_title can also be "Local Commit:", if you have unpushed commit (which also fills in $git_ancestor_line, eg: Summary of my perl5 (revision 5 version 21 subversion 1) configuration: Tony |
From @tonycozOn Sun Jun 15 23:06:36 2014, tonyc wrote:
Rejecting as discussed. Tony |
|
@tonycoz - Status changed from 'open' to 'rejected' |
Migrated from rt.perl.org#122097 (status was 'rejected')
Searchable as RT122097$
The text was updated successfully, but these errors were encountered: