Skip to content

perltodo: Update directories needing hand-rolled TAP #14834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
p5pRT opened this issue Aug 2, 2015 · 5 comments
Closed

perltodo: Update directories needing hand-rolled TAP #14834

p5pRT opened this issue Aug 2, 2015 · 5 comments

Comments

@p5pRT
Copy link

p5pRT commented Aug 2, 2015

Migrated from rt.perl.org#125736 (status was 'resolved')

Searchable as RT125736$

@p5pRT
Copy link
Author

p5pRT commented Aug 2, 2015

From @jkeenan

The list of directories in 'perltodo' in which t/test.pl may not be used is out-of-date.

Please review patch attached to see if it brings that list up-to-date correctly.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Aug 2, 2015

From @jkeenan

0001-Bring-list-of-directories-requiring-custom-TAP-up-to.patch
From a04f08d4a33b9a3c82b5a313c78010af11eaa54b Mon Sep 17 00:00:00 2001
From: James E Keenan <[email protected]>
Date: Sun, 2 Aug 2015 09:15:52 -0400
Subject: [PATCH] Bring list of directories requiring custom TAP up-to-date.

The list of directories in 'perltodo' which t/test.pl may not be used and in
which hand-rolled TAP is required was out-of-date.  It did not reflect the
creation in 2012 of the t/opbasic directory.  It failed to include the t/comp
directory.
---
 Porting/todo.pod | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Porting/todo.pod b/Porting/todo.pod
index c3a3db1..1ed467f 100644
--- a/Porting/todo.pod
+++ b/Porting/todo.pod
@@ -71,8 +71,8 @@ instead there is an intentionally simpler library, F<t/test.pl>. However,
 quite a few tests in F<t/> have not been refactored to use it. Refactoring
 any of these tests, one at a time, is a useful thing TODO.
 
-The subdirectories F<base>, F<cmd> and F<comp>, that contain the most
-basic tests, should be excluded from this task.
+The subdirectories F<base>, F<cmd>, F<comp> and F<opbasic>, that contain the
+most basic tests, should be excluded from this task.
 
 =head2 Automate perldelta generation
 
-- 
1.9.1

@p5pRT
Copy link
Author

p5pRT commented Aug 2, 2015

From @jkeenan

Summary of my perl5 (revision 5 version 23 subversion 2) configuration​:
  Commit id​: a04f08d4a33b9a3c82b5a313c78010af11eaa54b
  Platform​:
  osname=linux, osvers=3.13.0-61-generic, archname=x86_64-linux
  uname='linux zareason 3.13.0-61-generic #100-ubuntu smp wed jul 29 11​:21​:34 utc 2015 x86_64 x86_64 x86_64 gnulinux '
  config_args='-des -Dusedevel'
  hint=recommended, useposix=true, d_sigaction=define
  useithreads=undef, usemultiplicity=undef
  use64bitint=define, use64bitall=define, uselongdouble=undef
  usemymalloc=n, bincompat5005=undef
  Compiler​:
  cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
  optimize='-O2',
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include'
  ccversion='', gccversion='4.8.4', gccosandvers=''
  intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
  d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
  ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
  alignbytes=8, prototype=define
  Linker and Libraries​:
  ld='cc', ldflags =' -fstack-protector -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /lib64 /usr/lib64
  libs=-lpthread -lnsl -ldb -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.19.so, so=so, useshrplib=false, libperl=libperl.a
  gnulibc_version='2.19'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
  cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector'

Characteristics of this binary (from libperl)​:
  Compile-time options​: HAS_TIMES PERLIO_LAYERS PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_HASH_FUNC_ONE_AT_A_TIME_HARD PERL_MALLOC_WRAP
  PERL_PRESERVE_IVUV PERL_USE_DEVEL USE_64_BIT_ALL
  USE_64_BIT_INT USE_LARGE_FILES USE_LOCALE
  USE_LOCALE_COLLATE USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC USE_LOCALE_TIME USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Aug 2 2015 09​:22​:23
  %ENV​:
  PERLBREW_BASHRC_VERSION="0.67"
  PERLBREW_HOME="/home/jkeenan/.perlbrew"
  PERLBREW_MANPATH="/home/jkeenan/perl5/perlbrew/perls/perl-5.22.0/man"
  PERLBREW_PATH="/home/jkeenan/perl5/perlbrew/bin​:/home/jkeenan/perl5/perlbrew/perls/perl-5.22.0/bin"
  PERLBREW_PERL="perl-5.22.0"
  PERLBREW_ROOT="/home/jkeenan/perl5/perlbrew"
  PERLBREW_VERSION="0.67"
  PERL_WORKDIR="gitwork/perl"
  @​INC​:
  lib
  /usr/local/lib/perl5/site_perl/5.23.2/x86_64-linux
  /usr/local/lib/perl5/site_perl/5.23.2
  /usr/local/lib/perl5/5.23.2/x86_64-linux
  /usr/local/lib/perl5/5.23.2
  .

@p5pRT
Copy link
Author

p5pRT commented Aug 6, 2015

From @jkeenan

Pushed to blead in commit f3227d3. Marking ticket Resolved.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Aug 6, 2015

@jkeenan - Status changed from 'new' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant