Blead breaks Text-Diff-1.44

[p5pRT]

Migrated from rt.perl.org#131851 (status was 'resolved')

Searchable as RT131851$

[p5pRT]

From @jkeenan

A recent commit to Perl 5 blead has broken CPAN module Text​::Diff
version 1.44.

This was called to my attention by Carlos Guevara; see, e.g.,
http​://fast-matrix.cpantesters.org/?dist=Text%3A%3ADiff.

No errors were observed at fde84d2. Errors observed at d819dc5 were​:

#####
$ /testing/blead/bin/prove -I/testing/blead/lib -vb t/outputs.t
t/outputs.t ..
1..8
# Running under perl version 5.027003 for linux
# Current time local​: Mon Aug 7 09​:02​:37 2017
# Current time GMT​: Mon Aug 7 13​:02​:37 2017
# Using Test.pm version 1.30
ok 1
ok 2
ok 3
ok 4
ok 5
not ok 6
ok 7
ok 8
# Failed test 6 in t/outputs.t at line 54
# t/outputs.t line 54 is​: ok 0 < index( diff( \"\n", \"", { STYLE =>
"Table" } ), "\\n" );
Failed 1/8 subtests

Test Summary Report

---

t/outputs.t (Wstat​: 0 Tests​: 8 Failed​: 1)
  Failed test​: 6
Files=1, Tests=8, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.02 cusr
0.00 csys = 0.04 CPU)
Result​: FAIL
#####

Not yet bisected.

Thank you very much.
Jim Keenan

[p5pRT]

From @jkeenan

Summary of my perl5 (revision 5 version 27 subversion 3) configuration​:
  Commit id​: d819dc5
  Platform​:
  osname=linux
  osvers=4.4.0-89-generic
  archname=x86_64-linux
  uname='linux zareason 4.4.0-89-generic #112-ubuntu smp mon jul 31 19​:38​:41 utc 2017 x86_64 x86_64 x86_64 gnulinux '
  config_args='-des -Dusedevel -Uversiononly -Dprefix=/home/jkeenan/testing/blead -Dman1dir=none -Dman3dir=none'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=undef
  usemymalloc=n
  default_inc_excludes_dot=define
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
  optimize='-O2'
  cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='5.4.0 20160609'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='double'
  nvsize=8
  Off_t='off_t'
  lseeksize=8
  alignbytes=8
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/5/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib /lib64 /usr/lib64
  libs=-lpthread -lnsl -ldb -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.23.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.23'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  HAS_TIMES
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Aug 7 2017 08​:54​:17
  %ENV​:
  PERLBREW_BASHRC_VERSION="0.78"
  PERLBREW_HOME="/home/jkeenan/.perlbrew"
  PERLBREW_MANPATH="/home/jkeenan/perl5/perlbrew/perls/perl-5.26.0/man"
  PERLBREW_PATH="/home/jkeenan/perl5/perlbrew/bin​:/home/jkeenan/perl5/perlbrew/perls/perl-5.26.0/bin"
  PERLBREW_PERL="perl-5.26.0"
  PERLBREW_ROOT="/home/jkeenan/perl5/perlbrew"
  PERLBREW_VERSION="0.78"
  PERL_WORKDIR="/home/jkeenan/gitwork/perl"
  @​INC​:
  lib
  /home/jkeenan/testing/blead/lib/perl5/site_perl/5.27.3/x86_64-linux
  /home/jkeenan/testing/blead/lib/perl5/site_perl/5.27.3
  /home/jkeenan/testing/blead/lib/perl5/5.27.3/x86_64-linux
  /home/jkeenan/testing/blead/lib/perl5/5.27.3

[p5pRT]

From @iabyn

On Mon, Aug 07, 2017 at 06​:12​:02AM -0700, James E Keenan wrote​:

A recent commit to Perl 5 blead has broken CPAN module Text​::Diff
version 1.44.

This was called to my attention by Carlos Guevara; see, e.g.,
http​://fast-matrix.cpantesters.org/?dist=Text%3A%3ADiff.

No errors were observed at fde84d2. Errors observed at d819dc5 were​:

#####
$ /testing/blead/bin/prove -I/testing/blead/lib -vb t/outputs.t
t/outputs.t ..
1..8
# Running under perl version 5.027003 for linux
# Current time local​: Mon Aug 7 09​:02​:37 2017
# Current time GMT​: Mon Aug 7 13​:02​:37 2017
# Using Test.pm version 1.30
ok 1
ok 2
ok 3
ok 4
ok 5
not ok 6
ok 7
ok 8
# Failed test 6 in t/outputs.t at line 54
# t/outputs.t line 54 is​: ok 0 < index( diff( \"\n", \"", { STYLE =>
"Table" } ), "\\n" );
Failed 1/8 subtests

should be fixed by the following​:

commit 25f3319
Author​: David Mitchell <davem@​iabyn.com>
AuthorDate​: Mon Aug 7 16​:58​:11 2017 +0100
Commit​: David Mitchell <davem@​iabyn.com>
CommitDate​: Mon Aug 7 17​:11​:44 2017 +0100

  fix index(...) == -1 type optimisations
 
  RT #131851
 
  It was incorrectly optimising some permutations of comparison op and 0/-1
  which shouldn't have been, such as
 
  0 < index(...);

--
Please note that ash-trays are provided for the use of smokers,
whereas the floor is provided for the use of all patrons.
  -- Bill Royston

[p5pRT]

The RT System itself - Status changed from 'new' to 'open'

[p5pRT]

From @jkeenan

On Mon, 07 Aug 2017 16​:37​:50 GMT, davem wrote​:

On Mon, Aug 07, 2017 at 06​:12​:02AM -0700, James E Keenan wrote​:

A recent commit to Perl 5 blead has broken CPAN module Text​::Diff
version 1.44.

This was called to my attention by Carlos Guevara; see, e.g.,
http​://fast-matrix.cpantesters.org/?dist=Text%3A%3ADiff.

No errors were observed at fde84d2. Errors observed at d819dc5
were​:

#####
$ /testing/blead/bin/prove -I/testing/blead/lib -vb t/outputs.t
t/outputs.t ..
1..8
# Running under perl version 5.027003 for linux
# Current time local​: Mon Aug 7 09​:02​:37 2017
# Current time GMT​: Mon Aug 7 13​:02​:37 2017
# Using Test.pm version 1.30
ok 1
ok 2
ok 3
ok 4
ok 5
not ok 6
ok 7
ok 8
# Failed test 6 in t/outputs.t at line 54
# t/outputs.t line 54 is​: ok 0 < index( diff( \"\n",
\"", { STYLE =>
"Table" } ), "\\n" );
Failed 1/8 subtests

should be fixed by the following​:

commit 25f3319
Author​: David Mitchell <davem@​iabyn.com>
AuthorDate​: Mon Aug 7 16​:58​:11 2017 +0100
Commit​: David Mitchell <davem@​iabyn.com>
CommitDate​: Mon Aug 7 17​:11​:44 2017 +0100

fix index(...) == -1 type optimisations

RT #131851

It was incorrectly optimising some permutations of comparison op and
0/-1
which shouldn't have been, such as

0 < index(...);

Confirmed at commit 13f60a0​:

#####
Building and testing Text-Diff-1.44 ... cp lib/Text/Diff.pm blib/lib/Text/Diff.pm
...
t/outputs.t ..... ok
t/table.t ....... ok
All tests successful.
Files=9, Tests=33, 0 wallclock secs ( 0.04 usr 0.00 sys + 0.17 cusr 0.01 csys = 0.22 CPU)
Result​: PASS
...
Successfully installed Text-Diff-1.44
#####

Marking ticket Resolved.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

[p5pRT]

@jkeenan - Status changed from 'open' to 'resolved'