BBC: Blead Breaks Statistics::CaseResampling

[cjg-cguevara]

This is a bug report for perl from "Carlos Guevara" [email protected],
generated with the help of perlbug 1.43 running under perl 5.41.6.

---

BBC: Blead Breaks Statistics::CaseResampling

Please see http://fast-matrix.cpantesters.org/?dist=Statistics::CaseResampling

---

Flags

• category=core
• severity=low

---

Perl configuration

Site configuration information for perl 5.41.6:

Configured by cpan at Sun Oct 20 22:36:51 EDT 2024.

Summary of my perl5 (revision 5 version 41 subversion 6) configuration:
  Commit id: cb2baa70118e364c1428dc77cb8f9c614060c26e
  Platform:
    osname=linux
    osvers=5.14.0-427.40.1.el9_4.x86_64
    archname=x86_64-linux
    uname='linux cjg-rhel9 5.14.0-427.40.1.el9_4.x86_64 #1 smp preempt_dynamic fri oct 4 15:22:45 edt 2024 x86_64 x86_64 x86_64 gnulinux '
    config_args='-des -Dprefix=/home/cpan/bin/perl -Dscriptdir=/home/cpan/bin/perl/bin -Dusedevel -Duse64bitall'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=undef
    usemultiplicity=undef
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
  Compiler:
    cc='cc'
    ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2'
    optimize='-O2'
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion=''
    gccversion='11.4.1 20231218 (Red Hat 11.4.1-3)'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='cc'
    ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib /usr/lib64 /usr/local/lib64
    libs=-lpthread -ldb -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -ldl -lm -lcrypt -lutil -lc
    libc=/lib/../lib64/libc.so.6
    so=so
    useshrplib=false
    libperl=libperl.a
    gnulibc_version='2.34'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=so
    d_dlsymun=undef
    ccdlflags='-Wl,-E'
    cccdlflags='-fPIC'
    lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'


---
@INC for perl 5.41.6:
    /home/cpan/bin/perl/lib/site_perl/5.41.6/x86_64-linux
    /home/cpan/bin/perl/lib/site_perl/5.41.6
    /home/cpan/bin/perl/lib/5.41.6/x86_64-linux
    /home/cpan/bin/perl/lib/5.41.6

---
Environment for perl 5.41.6:
    HOME=/home/cpan
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LC_ALL=C
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/cpan/bin/perl/bin:/home/cpan/bin:/usr/share/Modules/bin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
    PERL_BADLANG (unset)
    SHELL=/bin/bash

[mauke]

Error message:

Unparseable XSUB parameter: 'confidence...' in CaseResampling.xs, line 325

[jkeenan]

Breaking commit:

a399a4923c7f15aa1aa5bdb38a5dccf59ef51678 is the first bad commit
commit a399a4923c7f15aa1aa5bdb38a5dccf59ef51678
Author: David Mitchell <[email protected]>
Date:   Mon Sep 23 18:52:11 2024 +0100

    ParseXS: refactor: XSUB signature-processing

[iabyn]

On Sun, Oct 20, 2024 at 09:52:52PM -0700, mauke wrote: Error message: ``` Unparseable XSUB parameter: 'confidence...' in CaseResampling.xs, line 325

Thus one is slightly different than the other recent XS breakages. The XS declaration is: median_simple_confidence_limits(sample, confidence...) It seems likely that the author intended to write median_simple_confidence_limits(sample, confidence, ...) but the ellipsis handling in XS was broken. It would basically do s/\.\.\.//g, so anything with an ellipsis would get broken. For example foo(int a, char *s = "and so ...") used to convert the default value to: foo(int a, char *s = "and so ") So IMHO, it's definitely a bug in the XS module, and the fix in XS in the XS parser is correct and should remain.

…

-- In my day, we used to edit the inodes by hand. With magnets.

[iabyn]

On Tue, Oct 22, 2024 at 04:26:14AM -0700, David Mitchell wrote: Thus one is slightly different than the other recent XS breakages. The XS declaration is: median_simple_confidence_limits(sample, confidence...)

[snip]

So IMHO, it's definitely a bug in the XS module, and the fix in XS in the XS parser is correct and should remain.

Now reported as https://rt.cpan.org/Ticket/Display.html?id=157217

…

-- Dave's first rule of Opera: If something needs saying, say it: don't warble it.