h2xs is broken

[p5pRT]

Migrated from rt.perl.org#37525 (status was 'resolved')

Searchable as RT37525$

[p5pRT]

From [email protected]

Hi,

You have a bug in the parameter parsing stage of h2xs, it aborts if
any [extra_libraries] are specified, because you have this line of
code in there​:-

GetOptions(%options) || usage;

but "-l" is not dealt with until later in your code. Changing the
above to this fixes the problem​:-

GetOptions(%options); # || usage;

FYI​:-

SYNOPSIS
  h2xs [OPTIONS ...] [headerfile ... [extra_libraries]]

EXAMPLES
  h2xs rpcsvc/rusers -L/opt/net/lib -lrpc

# h2xs rpcsvc/rusers -L/opt/net/lib -lrpc
Unknown option​: L/opt/net/lib
Unknown option​: lrpc
h2xs [OPTIONS ... ] [headerfile [extra_libraries]]
version​: 1.22
[snip]
extra_libraries
  are any libraries that might be needed for loading the
  extension, e.g. -lm would try to link in the math library.
#

(ends, doing nothing)

Kind Regards,
Chris Drake

[p5pRT]

From @smpeters

[christopher - Mon Oct 24 23​:49​:35 2005]​:

Hi,

You have a bug in the parameter parsing stage of h2xs, it aborts if
any [extra_libraries] are specified, because you have this line of
code in there​:-

GetOptions(%options) || usage;

but "-l" is not dealt with until later in your code. Changing the
above to this fixes the problem​:-

GetOptions(%options); # || usage;

FYI​:-

SYNOPSIS
h2xs [OPTIONS ...] [headerfile ... [extra_libraries]]

EXAMPLES
h2xs rpcsvc/rusers -L/opt/net/lib -lrpc

# h2xs rpcsvc/rusers -L/opt/net/lib -lrpc
Unknown option​: L/opt/net/lib
Unknown option​: lrpc
h2xs [OPTIONS ... ] [headerfile [extra_libraries]]
version​: 1.22
[snip]
extra_libraries
are any libraries that might be needed for loading the
extension, e.g. -lm would try to link in the math library.
#

(ends, doing nothing)

h2xs was broken.

h2xs rpcsvc/rusers -L/opt/net/lib -lrpc
Defaulting to backwards compatibility with perl 5.8.6
If you intend this module to be compatible with earlier perl versions,
please
specify a minimum perl version with the -b option.

Writing Rusers/ppport.h
Writing Rusers/lib/Rusers.pm
Writing Rusers/Rusers.xs
Writing Rusers/fallback/const-c.inc
Writing Rusers/fallback/const-xs.inc
Writing Rusers/Makefile.PL
Writing Rusers/README
Writing Rusers/t/Rusers.t
Writing Rusers/Changes
Writing Rusers/MANIFEST

h2xs -h
h2xs [OPTIONS ... ] [headerfile [extra_libraries]]
version​: 1.9

It looks like you have a very old version of h2xs, and the problems
you're seeing have since been fixed.

[p5pRT]

The RT System itself - Status changed from 'new' to 'open'

[p5pRT]

@smpeters - Status changed from 'open' to 'resolved'