Skip to content

Commit cf96688

Browse files
committed
Merge pull request #384 from jakobwilm/visualizer-fixes
Changed vtkRenderer::Render() to vtkRenderWindow::Render()
2 parents f28c6e4 + c60cbc0 commit cf96688

File tree

1 file changed

+5
-18
lines changed

1 file changed

+5
-18
lines changed

visualization/src/pcl_visualizer.cpp

Lines changed: 5 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -912,7 +912,6 @@ pcl::visualization::PCLVisualizer::removeActorFromRenderer (const vtkSmartPointe
912912
if (viewport == 0)
913913
{
914914
renderer->RemoveActor (actor);
915-
// renderer->Render ();
916915
}
917916
else if (viewport == i) // add the actor only to the specified viewport
918917
{
@@ -925,7 +924,6 @@ pcl::visualization::PCLVisualizer::removeActorFromRenderer (const vtkSmartPointe
925924
if (current_actor != actor_to_remove)
926925
continue;
927926
renderer->RemoveActor (actor);
928-
// renderer->Render ();
929927
// Found the correct viewport and removed the actor
930928
return (true);
931929
}
@@ -952,7 +950,6 @@ pcl::visualization::PCLVisualizer::removeActorFromRenderer (const vtkSmartPointe
952950
if (viewport == 0)
953951
{
954952
renderer->RemoveActor (actor);
955-
// renderer->Render ();
956953
}
957954
else if (viewport == i) // add the actor only to the specified viewport
958955
{
@@ -965,7 +962,6 @@ pcl::visualization::PCLVisualizer::removeActorFromRenderer (const vtkSmartPointe
965962
if (current_actor != actor_to_remove)
966963
continue;
967964
renderer->RemoveActor (actor);
968-
// renderer->Render ();
969965
// Found the correct viewport and removed the actor
970966
return (true);
971967
}
@@ -990,12 +986,10 @@ pcl::visualization::PCLVisualizer::addActorToRenderer (const vtkSmartPointer<vtk
990986
if (viewport == 0)
991987
{
992988
renderer->AddActor (actor);
993-
// renderer->Render ();
994989
}
995990
else if (viewport == i) // add the actor only to the specified viewport
996991
{
997992
renderer->AddActor (actor);
998-
// renderer->Render ();
999993
}
1000994
++i;
1001995
}
@@ -1017,7 +1011,6 @@ pcl::visualization::PCLVisualizer::removeActorFromRenderer (const vtkSmartPointe
10171011
if (viewport == 0)
10181012
{
10191013
renderer->RemoveActor (actor);
1020-
// renderer->Render ();
10211014
}
10221015
else if (viewport == i) // add the actor only to the specified viewport
10231016
{
@@ -1030,7 +1023,6 @@ pcl::visualization::PCLVisualizer::removeActorFromRenderer (const vtkSmartPointe
10301023
if (current_actor != actor_to_remove)
10311024
continue;
10321025
renderer->RemoveActor (actor);
1033-
// renderer->Render ();
10341026
// Found the correct viewport and removed the actor
10351027
return (true);
10361028
}
@@ -1256,12 +1248,10 @@ pcl::visualization::PCLVisualizer::setBackgroundColor (
12561248
if (viewport == 0)
12571249
{
12581250
renderer->SetBackground (r, g, b);
1259-
// renderer->Render ();
12601251
}
12611252
else if (viewport == i) // add the actor only to the specified viewport
12621253
{
12631254
renderer->SetBackground (r, g, b);
1264-
// renderer->Render ();
12651255
}
12661256
++i;
12671257
}
@@ -1636,9 +1626,7 @@ pcl::visualization::PCLVisualizer::updateCamera ()
16361626
PCL_WARN ("[pcl::visualization::PCLVisualizer::updateCamera()] This method was deprecated, just re-rendering all scenes now.");
16371627
rens_->InitTraversal ();
16381628
// Update the camera parameters
1639-
vtkRenderer* renderer = NULL;
1640-
while ((renderer = rens_->GetNextItem ()) != NULL)
1641-
renderer->Render ();
1629+
win_->Render ();
16421630
}
16431631

16441632
/////////////////////////////////////////////////////////////////////////////////////////////
@@ -1792,10 +1780,10 @@ pcl::visualization::PCLVisualizer::setCameraPosition (
17921780
cam->SetPosition (pos_x, pos_y, pos_z);
17931781
cam->SetFocalPoint (view_x, view_y, view_z);
17941782
cam->SetViewUp (up_x, up_y, up_z);
1795-
renderer->Render ();
17961783
}
17971784
++i;
17981785
}
1786+
win_->Render ();
17991787
}
18001788

18011789
/////////////////////////////////////////////////////////////////////////////////////////////
@@ -1815,10 +1803,10 @@ pcl::visualization::PCLVisualizer::setCameraPosition (
18151803
vtkSmartPointer<vtkCamera> cam = renderer->GetActiveCamera ();
18161804
cam->SetPosition (pos_x, pos_y, pos_z);
18171805
cam->SetViewUp (up_x, up_y, up_z);
1818-
renderer->Render ();
18191806
}
18201807
++i;
18211808
}
1809+
win_->Render ();
18221810
}
18231811

18241812
/////////////////////////////////////////////////////////////////////////////////////////////
@@ -1864,11 +1852,10 @@ pcl::visualization::PCLVisualizer::setCameraParameters (const Eigen::Matrix3f &i
18641852
cam->SetViewAngle (fovy);
18651853
cam->SetClippingRange (0.01, 1000.01);
18661854
win_->SetSize (window_size[0], window_size[1]);
1867-
1868-
renderer->Render ();
18691855
}
18701856
++i;
18711857
}
1858+
win_->Render ();
18721859
}
18731860

18741861
/////////////////////////////////////////////////////////////////////////////////////////////
@@ -1972,8 +1959,8 @@ pcl::visualization::PCLVisualizer::resetCameraViewpoint (const std::string &id)
19721959

19731960
renderer->SetActiveCamera (cam);
19741961
renderer->ResetCameraClippingRange ();
1975-
renderer->Render ();
19761962
}
1963+
win_->Render ();
19771964
}
19781965

19791966
//////////////////////////////////////////////////////////////////////////////////////////////

0 commit comments

Comments
 (0)