Refactor again

Author: johlju

Meta.Tests.ps1

@@ -1092,42 +1092,34 @@ Describe 'Common Tests - Spellcheck Files' -Tag 'Spellcheck' {
                 $spellcheckSettingsFilePath = $null
             }
 
+            $cSpellArgumentList = @(
+                '"**/*.md"',
+                '--no-color'
+            )
 
+            if ($spellcheckSettingsFilePath)
             {
-                <#
-                    cSpell returns a verbose string in the error stream
-                    "CSpell: Files checked: X, Issues found: Y in Z files".
-                    It will return this in the error stream regardless if there
-                    are any errors or not.
-                    See issue https://github.com/Jason3S/cspell/issues/61.
-                    This will redirect the output stream to file to be output
-                    after the test fail.
-                #>
-                try
-                {
-                    if ($spellcheckSettingsFilePath)
-                    {
-                        & cspell '**/*.md' --no-color --config $spellcheckSettingsFilePath >SpellingErrors.txt
-                    }
-                    else
-                    {
-                        & cspell '**/*.md' --no-color >SpellingErrors.txt
-                    }
-                }
-                catch
-                {
-                    $noErrorsRegEx = 'CSpell: Files checked: [0-9]+, Issues found: [0] in [0-9]+ files'
-                    Write-Verbose $_.Exception.Message -Verbose
-                    <#
-                        Only throw an error if there are 0 issues found in the
-                        error message.
-                    #>
-                    if (-not $_.Exception.Message -match $noErrorsRegEx)
-                    {
-                        throw $_.Exception.Message
-                    }
-                }
-            } | Should -Not -Throw
+                $cSpellArgumentList += @(
+                    '--config',
+                    $spellcheckSettingsFilePath
+                )
+            }
+
+            # This must be last, we send output to the error file.
+            $cSpellArgumentList += @(
+                ('>{0}' -f $errorFileName)
+            )
+
+            $startProcessParameters = @{
+                FilePath = 'cspell'
+                ArgumentList = $cSpellArgumentList
+                Wait = $true
+                PassThru = $true
+                NoNewWindow = $true
+            }
+
+            $process = Start-Process @startProcessParameters
+            $process.ExitCode | Should -Be 0
         } -ErrorVariable itBlockError
 
         # If the It-block did not pass the test, output the spelling errors.