Skip to content

Major glitch in formatting for code samples in about_ files on TechNet #950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jaykul opened this issue Jan 12, 2017 · 9 comments
Closed

Comments

@Jaykul
Copy link
Contributor

Jaykul commented Jan 12, 2017

The code examples are a total mess, for example, the ones in about_Comparison_Operators

image

@doctordns
Copy link
Contributor

Is this a glitch in how MSDN formats the pages? Or is this an issue with the markdown on the page itself?

@Jaykul
Copy link
Contributor Author

Jaykul commented Jan 15, 2017

The markdown is wrong. All of those numbers have a "#" in front of them turning them into headers.

@doctordns
Copy link
Contributor

I just took a look - yes. The markdown itself is a bit of a mess. I am happy to take a stab at getting this into better shape!

@doctordns
Copy link
Contributor

I have gone through this document, adding markdown for the examples, removing the # tags around the place and trying to make this better. I've issues a pull request - hopefully this revolves that problem!

@Jaykul
Copy link
Contributor Author

Jaykul commented Jan 16, 2017

I think it's most of the about_ files though. I mean, I just spot-checked:

  • about_trap and about_Remote_Jobs have good code examples, actually in code blocks, and with syntax highlighting (even when it shouldn't be highlighted).
  • about_arithmetic_operators, about_assignment_operators, about_commonparameters have the really bad code examples (like about_Comparison_Operators)
  • about_Remote, about_Remote_Variables, and about_regular_expressions have no markup on their code examples at all (which I think is basically the same as the ones with the really bad code examples, except there just happened to not be # in the example code...)

@doctordns
Copy link
Contributor

Thanks Jaykul. There is much work to be done. Once the current pull request is actioned, I am happy to work through those about_* files to correct them. Unless of course someone beats me to it.

@zjalexander
Copy link
Contributor

Yeah, there's a general scrub of about_ topics that's called for at this point.
https://msdn.microsoft.com/en-us/powershell/reference/3.0/psworkflow/about/about_workflows
https://msdn.microsoft.com/en-us/powershell/reference/3.0/psworkflow/about/about_activitycommonparameters
https://msdn.microsoft.com/en-us/powershell/reference/3.0/microsoft.powershell.core/about/about_aliases

some are missing proper formatting. all are missing proper links in the "see also" section. I got to talk to @juanpablojofre and see if he had some tooling developed since it's not consistent across all about files and all versions, and I remember the process of getting stuff into markdown was quite .... iterative.

@Xalorous
Copy link

Xalorous commented Jun 27, 2017

I see styling with markdown is accepted here in the comments, what about the "about_" pages?

The 'about_regular_expressions' page is an unformatted copy/pasta of output from Get-Help about_regular_expressions, but the help output contains space delimited tables that translate very poorly. The website needs it converted to a table somehow, but I don't know the formatting used to go from what's on the github to what's seen on technet.

Edit: I just tested, the unformatted text in about_regular_expressions previews nicely when re-done using markdown. However, I did not find what I needed in that text, and I do not have time to convert the whole text, PLUS the other about_* files also need some treatment, and it would be better done using some programmatic method, to ensure uniformity. My text parsing skills are basically non-existent. Perhaps someone has access to the source files that were used to create the help file? Might be easier to reformat those, or use those to create the technet page.

@zjalexander
Copy link
Contributor

yup, markdown in the about_ topics is definitely allowed. we've fixed a few (about_pipelines at least, from #1262 ). I think @juanpablojofre had a plan for the rest according to a meeting today?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants