Skip to content

Re-write IPLD lessons to new API #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikeal opened this issue Nov 5, 2018 · 2 comments
Closed

Re-write IPLD lessons to new API #79

mikeal opened this issue Nov 5, 2018 · 2 comments
Assignees
Milestone

Comments

@mikeal
Copy link
Member

mikeal commented Nov 5, 2018

The CBOR API changes have been merged upstream into the latest IPFS. This means we need to:

  • Update the version of js-ipfs in the lessons.
  • Update the IPLD lessons to use the new API
    • Replace {"/": cid.toBaseEncodedString()} with cid.
@terichadbourne
Copy link
Member

@mikeal Are you game to take on fixing the lesson itself, with any instruction changes that are immediately obvious to you, and then I can go back through and proof it for comprehensibility in its new form?

I'll reference the old issue when I do that, as there was some stuff like suggesting a while loop that's unrelated to the change in how the API works.

@terichadbourne terichadbourne added this to the 1.0 milestone Nov 9, 2018
@mikeal
Copy link
Member Author

mikeal commented Nov 9, 2018

I'll do the first pass and then hand it off to you for review and merger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants