Reverting to Syncthing's Windows symlink workaround for the time being as SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE is not yet implemented in Go's implementation for Window's symlinks as of 1.9.2 - golang/go#22874

Signed-off-by: Nicholas Rishel <[email protected]>

Author: PrototypeNM1

lib/scanner/walk_test.go

@@ -378,7 +378,7 @@ func TestWalkRootSymlink(t *testing.T) {
 
 	link := tmp + "/link"
 	dest, _ := filepath.Abs("testdata/dir1")
-	if err := os.Symlink(dest, link); err != nil {
+	if err := osutil.DebugSymlinkForTestsOnly(dest, link); err != nil {
 		if runtime.GOOS == "windows" {
 			// Probably we require permissions we don't have.
 			t.Skip("Need admin permissions or developer mode to run symlink test on Windows: " + err.Error())