Skip to content

Partially revert #1326 #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Partially revert #1326 #1406

wants to merge 1 commit into from

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • Write a good description on what the PR does.

Description

This fixes the issues @cdce8p identified in #1326.

Type of Changes

Type
✓ 🐛 Bug fix

Related Issue

@DanielNoord DanielNoord added this to the 2.10.0 milestone Feb 26, 2022
cdce8p
cdce8p requested changes Feb 26, 2022
View reviewed changes
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to help unfortunately. Still seeing the regression and debug log messages with the patch applied.

Maybe for the time being, it's better to completely revert #1326 and start from there again.

@DanielNoord DanielNoord mentioned this pull request Feb 27, 2022
Merged
@DanielNoord
Copy link
Collaborator Author

Opened a PR to revert. @cdce8p How do you test this against home assistant? Does the standard Github action also show these debug messages?

@cdce8p
Copy link
Member

cdce8p commented Feb 27, 2022 •
edited
Loading

Does the standard Github action also show these debug messages?

It did for me.

How do you test this against home assistant?

I use my Home Assistant fork for that. Probably best if you take a look at cdce8p/ha-core#11, especially the first commit. (Just a warning, I rebase that branch quite often.)
Basically, I use the default pylint job, but install custom versions for pylint and astroid first. Those are based on my dev branches which normally follow main, except when I want to test some new changes.

@cdce8p cdce8p removed this from the 2.10.0 milestone Feb 27, 2022
@cdce8p
Copy link
Member

cdce8p commented Feb 27, 2022

Superseded by #1409

@cdce8p cdce8p closed this Feb 27, 2022
@DanielNoord DanielNoord deleted the pkg_resources branch February 27, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdce8p cdce8p cdce8p requested changes

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @cdce8p @Pierre-Sassoulas