-
-
Notifications
You must be signed in to change notification settings - Fork 477
refactor: Remove unused and duplicate imports #2787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Lumouille <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is failing
This looks like an issue with your type checker, not pycord |
well its still strange to have the discord utils being imported 2 times, and if its fix both why not merge it ;) |
I'll do some more investigation, so it's not ready for the moment |
so i did lot of testing (using different version of pylance etc) and seems that removing the double import just fix this all the time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have no idea where the problem comes from but I don't see an issue with the changes made
|
i'll check all around the lib for all unused import to removed them later (prob around end july) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have to look into this more
Summary
the type checker where not able to find discord.utils because of the http leading to no suggestion for everyfunction of utils like discord.utils.get etc etc
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.