Skip to content

Commit b6a7fda

Browse files
committed
feat(ssg): report more errors
1 parent cbdf239 commit b6a7fda

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

packages/qwik-router/src/ssg/worker-thread.ts

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
import { _serialize } from '@qwik.dev/core/internal';
22
import type { ServerRequestEvent } from '@qwik.dev/router/middleware/request-handler';
3-
import { RequestEvShareQData, requestHandler } from '@qwik.dev/router/middleware/request-handler';
3+
import {
4+
RedirectMessage,
5+
RequestEvShareQData,
6+
requestHandler,
7+
} from '@qwik.dev/router/middleware/request-handler';
48
import { WritableStream } from 'node:stream/web';
59
import { pathToFileURL } from 'node:url';
610
import type { ClientPageData } from '../runtime/src/types';
@@ -152,6 +156,7 @@ async function workerRender(
152156
});
153157
}
154158
} catch (e: any) {
159+
console.error('Error during stream start', staticRoute.pathname, e);
155160
routeWriter = null;
156161
result.error = {
157162
message: String(e),
@@ -166,6 +171,7 @@ async function workerRender(
166171
routeWriter.write(Buffer.from(chunk.buffer));
167172
}
168173
} catch (e: any) {
174+
console.error('Error during stream write', staticRoute.pathname, e);
169175
routeWriter = null;
170176
result.error = {
171177
message: String(e),
@@ -219,6 +225,7 @@ async function workerRender(
219225
await Promise.all(writePromises);
220226
}
221227
} catch (e: any) {
228+
console.error('Error during stream close', staticRoute.pathname, e);
222229
routeWriter = null;
223230
result.error = {
224231
message: String(e),
@@ -242,8 +249,13 @@ async function workerRender(
242249
});
243250
}
244251
})
245-
.then((e) => {
252+
.then((e: any) => {
246253
if (e !== undefined) {
254+
if (e instanceof RedirectMessage) {
255+
// TODO We should render a html page for redirects too
256+
// that would require refactoring redirects
257+
return;
258+
}
247259
if (e instanceof Error) {
248260
result.error = {
249261
message: e.message,
@@ -256,6 +268,7 @@ async function workerRender(
256268
};
257269
}
258270
}
271+
console.error('Error during request handling', staticRoute.pathname, e);
259272
})
260273
.finally(() => {
261274
pendingPromises.delete(promise);
@@ -264,6 +277,7 @@ async function workerRender(
264277

265278
pendingPromises.add(promise);
266279
} catch (e: any) {
280+
console.error('Error during render', staticRoute.pathname, e);
267281
if (e instanceof Error) {
268282
result.error = {
269283
message: e.message,

0 commit comments

Comments
 (0)