Skip to content

Commit 335a57e

Browse files
committed
Revert "Support dartdevc, dart2js with shared source files, dartdevc sdk (flutter#8105)"
This reverts commit 7d0e7a7.
1 parent 27fa078 commit 335a57e

File tree

7 files changed

+215
-359
lines changed

7 files changed

+215
-359
lines changed

BUILD.gn

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@
44

55
import("$flutter_root/common/config.gni")
66

7-
# Whether to build the dartdevc sdk, libraries, and source files
8-
# required for the flutter web sdk.
9-
declare_args() {
10-
full_dart_sdk = false
11-
}
12-
137
group("flutter") {
148
testonly = true
159

@@ -29,13 +23,8 @@ group("flutter") {
2923
public_deps += [
3024
"$flutter_root/frontend_server",
3125
"//third_party/dart:create_sdk",
26+
"$flutter_root/web_sdk",
3227
]
33-
34-
if (full_dart_sdk) {
35-
public_deps += [
36-
"$flutter_root/web_sdk",
37-
]
38-
}
3928
}
4029
}
4130

ci/licenses_golden/licenses_flutter

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -704,7 +704,6 @@ FILE: ../../../flutter/vulkan/vulkan_utilities.cc
704704
FILE: ../../../flutter/vulkan/vulkan_utilities.h
705705
FILE: ../../../flutter/vulkan/vulkan_window.cc
706706
FILE: ../../../flutter/vulkan/vulkan_window.h
707-
FILE: ../../../flutter/web_sdk/flutter_kernel_sdk.dart
708707
FILE: ../../../flutter/web_sdk/libraries.json
709708
----------------------------------------------------------------------------------------------------
710709
Copyright 2013 The Flutter Authors. All rights reserved.

tools/gn

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -234,10 +234,8 @@ def to_gn_args(args):
234234
if args.arm_float_abi:
235235
gn_args['arm_float_abi'] = args.arm_float_abi
236236

237-
# Whether to build trained Dart SDK snapshots of dart2js and dartdevc,
238-
# including the web sdk kernel and source files.
237+
# Whether to build trained Dart SDK snapshots of dart2js and dartdevc.
239238
gn_args['dart_platform_sdk'] = not args.full_dart_sdk
240-
gn_args['full_dart_sdk'] = args.full_dart_sdk
241239

242240
return gn_args
243241

web_sdk/BUILD.gn

Lines changed: 38 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -2,82 +2,63 @@
22
# Use of this source code is governed by a BSD-style license that can be
33
# found in the LICENSE file.
44

5-
import("//third_party/dart/build/dart/dart_action.gni")
6-
import("//third_party/dart/utils/compile_platform.gni")
7-
8-
sdk_dill = "$root_out_dir/flutter_web_sdk/kernel/flutter_ddc_sdk.dill"
9-
sdk_libraries_json = "$flutter_root/web_sdk/libraries.json"
10-
11-
web_ui_sources = [
12-
"$flutter_root/lib/stub_ui/compositing.dart",
13-
"$flutter_root/lib/stub_ui/geometry.dart",
14-
"$flutter_root/lib/stub_ui/hash_codes.dart",
15-
"$flutter_root/lib/stub_ui/hooks.dart",
16-
"$flutter_root/lib/stub_ui/isolate_name_server.dart",
17-
"$flutter_root/lib/stub_ui/lerp.dart",
18-
"$flutter_root/lib/stub_ui/natives.dart",
19-
"$flutter_root/lib/stub_ui/painting.dart",
20-
"$flutter_root/lib/stub_ui/plugins.dart",
21-
"$flutter_root/lib/stub_ui/pointer.dart",
22-
"$flutter_root/lib/stub_ui/semantics.dart",
23-
"$flutter_root/lib/stub_ui/text.dart",
24-
"$flutter_root/lib/stub_ui/ui.dart",
25-
"$flutter_root/lib/stub_ui/versions.dart",
26-
"$flutter_root/lib/stub_ui/window.dart",
27-
]
28-
295
group("web_sdk") {
306
deps = [
317
":web_ui_sources",
32-
":web_ui_library",
33-
":flutter_dartdevc_kernel_sdk",
8+
":web_libraries_json",
9+
#":dart_sdk_internal",
3410
]
3511
}
3612

3713
copy("web_ui_sources") {
38-
sources = web_ui_sources
14+
sources = [
15+
"$flutter_root/lib/stub_ui/compositing.dart",
16+
"$flutter_root/lib/stub_ui/geometry.dart",
17+
"$flutter_root/lib/stub_ui/hash_codes.dart",
18+
"$flutter_root/lib/stub_ui/hooks.dart",
19+
"$flutter_root/lib/stub_ui/isolate_name_server.dart",
20+
"$flutter_root/lib/stub_ui/lerp.dart",
21+
"$flutter_root/lib/stub_ui/natives.dart",
22+
"$flutter_root/lib/stub_ui/painting.dart",
23+
"$flutter_root/lib/stub_ui/plugins.dart",
24+
"$flutter_root/lib/stub_ui/pointer.dart",
25+
"$flutter_root/lib/stub_ui/semantics.dart",
26+
"$flutter_root/lib/stub_ui/text.dart",
27+
"$flutter_root/lib/stub_ui/ui.dart",
28+
"$flutter_root/lib/stub_ui/versions.dart",
29+
"$flutter_root/lib/stub_ui/window.dart",
30+
]
3931

4032
outputs = [
4133
"$root_out_dir/flutter_web_sdk/lib/ui/{{source_file_part}}"
4234
]
4335
}
4436

45-
copy("web_ui_library") {
37+
copy("web_libraries_json") {
4638
sources = [
47-
"$flutter_root/web_sdk/libraries.json",
39+
"libraries.json"
4840
]
4941

5042
outputs = [
51-
"$root_out_dir/flutter_web_sdk/{{source_file_part}}"
43+
"$root_out_dir/flutter_web_sdk/lib/libraries.json"
5244
]
5345
}
5446

55-
prebuilt_dart_action("flutter_dartdevc_kernel_sdk") {
56-
deps = [
57-
"//third_party/dart/pkg:pkg_files_stamp",
58-
"//third_party/dart/utils/dartdevc:dartdevc_files_stamp",
59-
"//third_party/dart/utils/dartdevc:dartdevc_sdk_patch_stamp",
60-
]
47+
# copy("dart_sdk_internal") {
48+
# deps = [
49+
# "//third_party/dart:create_sdk"
50+
# ]
6151

62-
inputs = [
63-
"//third_party/dart/pkg/dev_compiler/tool/kernel_sdk.dart",
64-
]
52+
# sources = [
53+
# "$root_out_dir/dart-sdk/lib/_internal/ddc_sdk.dill",
54+
# "$root_out_dir/dart-sdk/lib/_internal/dart2js_platform.dill",
55+
# "$root_out_dir/dart-sdk/lib/_internal/dart2js_server_platform.dill",
56+
# "$root_out_dir/dart-sdk/lib/_internal/ddc_sdk.sum",
57+
# "$root_out_dir/dart-sdk/lib/_internal/strong.sum",
58+
# "$root_out_dir/dart-sdk/lib/_internal/vm_platform_strong.dill",
59+
# ]
6560

66-
outputs = [
67-
sdk_dill,
68-
"$root_out_dir/flutter_web_sdk/lib/_internal/libraries.json",
69-
"$root_out_dir/flutter_web_sdk/kernel/amd/dart_sdk.js",
70-
"$root_out_dir/flutter_web_sdk/kernel/amd/dart_sdk.js.map",
71-
]
72-
73-
script = "flutter_kernel_sdk.dart"
74-
packages = "//third_party/dart/.packages"
75-
76-
output_path = rebase_path(sdk_dill)
77-
libraries_path = rebase_path(sdk_libraries_json)
78-
79-
args = [
80-
"--output=$output_path",
81-
"--libraries=$libraries_path",
82-
]
83-
}
61+
# outputs = [
62+
# "$root_out_dir/flutter_web_sdk/lib/_internal/{{source_file_part}}"
63+
# ]
64+
# }

web_sdk/flutter_kernel_sdk.dart

Lines changed: 0 additions & 109 deletions
This file was deleted.

0 commit comments

Comments
 (0)