Skip to content

__forceinline__ doesn't imply inline #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jithunnair-amd opened this issue Jul 13, 2018 · 2 comments
Closed

__forceinline__ doesn't imply inline #572

jithunnair-amd opened this issue Jul 13, 2018 · 2 comments
Assignees
@mangupta

Comments

@jithunnair-amd
Copy link

jithunnair-amd commented Jul 13, 2018 •
edited by AlexVlx
Loading

HIP needs to handle __forceinline__ like CUDA does. Currently, based on the comment here: https://github.com/ROCm-Developer-Tools/HIP/blob/master/docs/markdown/hip_faq.md#what-if-hip-generates-error-of-symbol-multiply-defined-only-on-amd-machine
__forceinline__ doesn't imply inline.
@jithunnair-amd jithunnair-amd mentioned this issue Jul 13, 2018
Merged
@jithunnair-amd jithunnair-amd changed the title __forceinline__ doesn't imply static __forceinline__ doesn't imply inline Jul 16, 2018
@AlexVlx
Copy link
Contributor

AlexVlx commented Jul 24, 2018

#362 should be taken into account as well

@mangupta
Copy link
Contributor

This was fixed via e7352a1. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mangupta mangupta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mangupta @AlexVlx @jithunnair-amd