From fbd3f1f10e67fd992b12b289321f837785e8b8dd Mon Sep 17 00:00:00 2001 From: Johannes M Dieterich Date: Thu, 16 Aug 2018 10:08:43 -0500 Subject: [PATCH 1/2] Fix a long-standing warning when compiling on ROCm that ::abs is for integers only. Use the correct fabs() for double - similar to fabsf used for float. --- aten/src/THC/THCNumerics.cuh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aten/src/THC/THCNumerics.cuh b/aten/src/THC/THCNumerics.cuh index 0e79d7f84d9ea5..9e653b7934aaf5 100644 --- a/aten/src/THC/THCNumerics.cuh +++ b/aten/src/THC/THCNumerics.cuh @@ -663,7 +663,7 @@ struct THCNumerics { static inline __host__ __device__ double tanh (double a) { return ::tanh(a); } static inline __host__ __device__ double erf (double a) { return ::erf(a); } static inline __host__ __device__ double erfc (double a) { return ::erfc(a); } - static inline __host__ __device__ double abs (double a) { return ::abs(a); } + static inline __host__ __device__ double abs (double a) { return fabs(a); } static inline __host__ __device__ double round(double a) { return ::round(a); } static inline __host__ __device__ double frac (double a) { return a - ::trunc(a); } static inline __host__ __device__ double cinv (double a) { return 1.0 / a; } From dc22cac6585155dba40c3de0a0a7a9419eb348d9 Mon Sep 17 00:00:00 2001 From: Johannes M Dieterich Date: Thu, 16 Aug 2018 10:27:51 -0500 Subject: [PATCH 2/2] Remove a doubled entry. --- tools/amd_build/disabled_features.yaml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/tools/amd_build/disabled_features.yaml b/tools/amd_build/disabled_features.yaml index 9dd00f675b4acd..3b9c7c60b9b4b6 100644 --- a/tools/amd_build/disabled_features.yaml +++ b/tools/amd_build/disabled_features.yaml @@ -50,12 +50,6 @@ "#include ": "" } }, - { - "path": "aten/src/ATen/native/cuda/Distributions.cu", - "s_constants": { - "#include ": "" - } - }, { "path": "aten/src/THC/THCNumerics.cuh", "s_constants": {