From 772427e4d9aa253ea6e4dcb91463f203cd7bc204 Mon Sep 17 00:00:00 2001 From: Johannes M Dieterich Date: Thu, 16 Aug 2018 15:21:59 -0500 Subject: [PATCH 1/2] After the elementwise fix, these tests don't hang any longer. --- test/test_optim.py | 8 -------- 1 file changed, 8 deletions(-) diff --git a/test/test_optim.py b/test/test_optim.py index bc6e0ff8fc828f..9dbc1b23816c41 100644 --- a/test/test_optim.py +++ b/test/test_optim.py @@ -236,7 +236,6 @@ def _build_params_dict(self, weight, bias, **kwargs): def _build_params_dict_single(self, weight, bias, **kwargs): return [dict(params=bias, **kwargs)] - @skipIfRocm def test_sgd(self): self._test_rosenbrock( lambda params: optim.SGD(params, lr=1e-3), @@ -273,7 +272,6 @@ def test_sgd_sparse(self): lambda params: optim.SGD(params, lr=5e-3) ) - @skipIfRocm def test_adam(self): self._test_rosenbrock( lambda params: optim.Adam(params, lr=1e-2), @@ -311,7 +309,6 @@ def test_sparse_adam(self): with self.assertRaisesRegex(ValueError, "Invalid beta parameter at index 0: 1.0"): optim.SparseAdam(None, lr=1e-2, betas=(1.0, 0.0)) - @skipIfRocm def test_adadelta(self): self._test_rosenbrock( lambda params: optim.Adadelta(params), @@ -335,7 +332,6 @@ def test_adadelta(self): with self.assertRaisesRegex(ValueError, "Invalid rho value: 1.1"): optim.Adadelta(None, lr=1e-2, rho=1.1) - @skipIfRocm def test_adagrad(self): self._test_rosenbrock( lambda params: optim.Adagrad(params, lr=1e-1), @@ -369,7 +365,6 @@ def test_adagrad_sparse(self): lambda params: optim.Adagrad(params, lr=1e-1) ) - @skipIfRocm def test_adamax(self): self._test_rosenbrock( lambda params: optim.Adamax(params, lr=1e-1), @@ -394,7 +389,6 @@ def test_adamax(self): with self.assertRaisesRegex(ValueError, "Invalid beta parameter at index 1: 1.0"): optim.Adamax(None, lr=1e-2, betas=(0.0, 1.0)) - @skipIfRocm def test_rmsprop(self): self._test_rosenbrock( lambda params: optim.RMSprop(params, lr=1e-2), @@ -419,7 +413,6 @@ def test_rmsprop(self): with self.assertRaisesRegex(ValueError, "Invalid momentum value: -1.0"): optim.RMSprop(None, lr=1e-2, momentum=-1.0) - @skipIfRocm def test_asgd(self): self._test_rosenbrock( lambda params: optim.ASGD(params, lr=1e-3), @@ -469,7 +462,6 @@ def test_rprop(self): with self.assertRaisesRegex(ValueError, "Invalid eta values: 1.0, 0.5"): optim.Rprop(None, lr=1e-2, etas=(1.0, 0.5)) - @skipIfRocm def test_lbfgs(self): self._test_rosenbrock( lambda params: optim.LBFGS(params), From 66d224df536e8895cd5f34345484cd01723426df Mon Sep 17 00:00:00 2001 From: Johannes M Dieterich Date: Thu, 16 Aug 2018 16:13:12 -0500 Subject: [PATCH 2/2] This fails on the CI. --- test/test_optim.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_optim.py b/test/test_optim.py index 9dbc1b23816c41..9e46959d7901fb 100644 --- a/test/test_optim.py +++ b/test/test_optim.py @@ -365,6 +365,7 @@ def test_adagrad_sparse(self): lambda params: optim.Adagrad(params, lr=1e-1) ) + @skipIfRocm def test_adamax(self): self._test_rosenbrock( lambda params: optim.Adamax(params, lr=1e-1),