From 89098301e3ac7ee857fd6c6da798fb94df7e7db5 Mon Sep 17 00:00:00 2001 From: Johannes M Dieterich Date: Fri, 17 Aug 2018 10:35:30 -0500 Subject: [PATCH 1/4] Undo blacklisting of jit tests for ROCm. --- test/run_test.py | 1 - 1 file changed, 1 deletion(-) diff --git a/test/run_test.py b/test/run_test.py index 0c80581c7e51cb..a55b7bafaabcfa 100644 --- a/test/run_test.py +++ b/test/run_test.py @@ -45,7 +45,6 @@ 'cuda', 'distributed', 'distributions', - 'jit', 'legacy_nn', 'multiprocessing', 'nccl', From ee0dc420f4acefaad6ad19aad9d0d39bb7d985ea Mon Sep 17 00:00:00 2001 From: Johannes M Dieterich Date: Fri, 17 Aug 2018 10:47:47 -0500 Subject: [PATCH 2/4] One missing LAPACK, the other erroring on CUDA fusion missing CUDA. --- test/test_jit.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test_jit.py b/test/test_jit.py index 4f1c3f37034d33..e5e43a1c0d3f8e 100644 --- a/test/test_jit.py +++ b/test/test_jit.py @@ -555,6 +555,7 @@ def f(x, y): @unittest.skipIf(IS_WINDOWS, "NYI: fuser support for Windows") @unittest.skipIf(not RUN_CUDA, "fuser requires CUDA") + @skipIfRocm def test_fusion_rand(self): class M(torch.jit.ScriptModule): __constants__ = ['d'] @@ -6068,6 +6069,7 @@ def test_directory(self): export_type=torch.onnx.ExportTypes.DIRECTORY) shutil.rmtree(d) + @skipIfRocm def test_aten_fallback(self): class ModelWithAtenNotONNXOp(nn.Module): def forward(self, x, y): From 757a1e0f2664b715561328c41797b84fcc38b6cb Mon Sep 17 00:00:00 2001 From: Johannes M Dieterich Date: Fri, 17 Aug 2018 10:52:32 -0500 Subject: [PATCH 3/4] Hangs on ROCm. --- test/test_jit.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_jit.py b/test/test_jit.py index e5e43a1c0d3f8e..f9aa3face1597f 100644 --- a/test/test_jit.py +++ b/test/test_jit.py @@ -5823,6 +5823,7 @@ def forward(self, x): self.checkTrace(Policy(), (torch.rand(1, 4),)) + @skipIfRocm def test_snli(self): # TODO: # 1) nn.LSTM is called as a Python function https://github.com/pytorch/pytorch/issues/8449 From d98a40db0cb57411a8e5986dbcd5cae7ab3c18c8 Mon Sep 17 00:00:00 2001 From: Johannes M Dieterich Date: Fri, 17 Aug 2018 12:23:30 -0500 Subject: [PATCH 4/4] Fails on the CI w/ CUDA fusion group missing error. --- test/test_jit.py | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test_jit.py b/test/test_jit.py index f9aa3face1597f..884dc4d42d86e1 100644 --- a/test/test_jit.py +++ b/test/test_jit.py @@ -778,6 +778,7 @@ def broadcast(a, b): @unittest.skipIf(IS_WINDOWS, "NYI: fuser support for Windows") @unittest.skipIf(not RUN_CUDA_MULTI_GPU, "needs non-zero device") + @skipIfRocm def test_fuse_last_device(self): device = 'cuda:' + str(1) x = torch.tensor([0.4], dtype=torch.float, device=device)