diff --git a/caffe2/CMakeLists.txt b/caffe2/CMakeLists.txt index 32183e212c923c..67c7856354a31d 100644 --- a/caffe2/CMakeLists.txt +++ b/caffe2/CMakeLists.txt @@ -359,7 +359,7 @@ if(USE_ROCM) hip_add_library(caffe2_hip ${Caffe2_HIP_SRCS}) # Since PyTorch files contain HIP headers, these flags are required for the necessary definitions to be added. - set_target_properties(caffe2_hip PROPERTIES COMPILE_FLAGS ${HIP_HIPCC_FLAGS}) + target_compile_options(caffe2_hip PRIVATE ${HIP_HIPCC_FLAGS}) target_link_libraries(caffe2_hip PUBLIC caffe2) target_link_libraries(caffe2_hip PUBLIC ${Caffe2_HIP_DEPENDENCY_LIBS}) @@ -554,7 +554,7 @@ if (BUILD_PYTHON) if(USE_ROCM) hip_add_library(caffe2_pybind11_state_hip MODULE ${Caffe2_HIP_PYTHON_SRCS}) set_target_properties(caffe2_pybind11_state_hip PROPERTIES LINKER_LANGUAGE HIP) - set_target_properties(caffe2_pybind11_state_hip PROPERTIES COMPILE_FLAGS "${HIP_HIPCC_FLAGS} -fvisibility=hidden") + target_compile_options(caffe2_pybind11_state_hip PRIVATE ${HIP_HIPCC_FLAGS} -fvisibility=hidden) set_target_properties(caffe2_pybind11_state_hip PROPERTIES PREFIX "") set_target_properties(caffe2_pybind11_state_hip PROPERTIES SUFFIX ${PY_EXT_SUFFIX}) if (APPLE) diff --git a/cmake/Dependencies.cmake b/cmake/Dependencies.cmake index 67b65c0dcba74a..d8d8927a05241e 100644 --- a/cmake/Dependencies.cmake +++ b/cmake/Dependencies.cmake @@ -534,17 +534,17 @@ if(NOT BUILD_ATEN_MOBILE) message(INFO "Compiling with HIP for AMD.") caffe2_update_option(USE_ROCM ON) - set(HIP_HIPCC_FLAGS "${HIP_HIPCC_FLAGS} -fPIC") - set(HIP_HIPCC_FLAGS "${HIP_HIPCC_FLAGS} -D__HIP_PLATFORM_HCC__=1") - set(HIP_HIPCC_FLAGS "${HIP_HIPCC_FLAGS} -DCUDA_HAS_FP16=1") - set(HIP_HIPCC_FLAGS "${HIP_HIPCC_FLAGS} -D__HIP_NO_HALF_OPERATORS__=1") - set(HIP_HIPCC_FLAGS "${HIP_HIPCC_FLAGS} -D__HIP_NO_HALF_CONVERSIONS__=1") - set(HIP_HIPCC_FLAGS "${HIP_HIPCC_FLAGS} -Wno-macro-redefined") - set(HIP_HIPCC_FLAGS "${HIP_HIPCC_FLAGS} -Wno-inconsistent-missing-override") - set(HIP_HIPCC_FLAGS "${HIP_HIPCC_FLAGS} -Wno-exceptions") - set(HIP_HIPCC_FLAGS "${HIP_HIPCC_FLAGS} -Wno-shift-count-negative") - set(HIP_HIPCC_FLAGS "${HIP_HIPCC_FLAGS} -Wno-shift-count-overflow") - set(HIP_HIPCC_FLAGS "${HIP_HIPCC_FLAGS} -Wno-unused-command-line-argument") + list(APPEND HIP_HIPCC_FLAGS -fPIC) + list(APPEND HIP_HIPCC_FLAGS -D__HIP_PLATFORM_HCC__=1) + list(APPEND HIP_HIPCC_FLAGS -DCUDA_HAS_FP16=1) + list(APPEND HIP_HIPCC_FLAGS -D__HIP_NO_HALF_OPERATORS__=1) + list(APPEND HIP_HIPCC_FLAGS -D__HIP_NO_HALF_CONVERSIONS__=1) + list(APPEND HIP_HIPCC_FLAGS -Wno-macro-redefined) + list(APPEND HIP_HIPCC_FLAGS -Wno-inconsistent-missing-override) + list(APPEND HIP_HIPCC_FLAGS -Wno-exceptions) + list(APPEND HIP_HIPCC_FLAGS -Wno-shift-count-negative) + list(APPEND HIP_HIPCC_FLAGS -Wno-shift-count-overflow) + list(APPEND HIP_HIPCC_FLAGS -Wno-unused-command-line-argument) set(Caffe2_HIP_INCLUDES ${hip_INCLUDE_DIRS} ${hcc_INCLUDE_DIRS} ${hsa_INCLUDE_DIRS} ${rocrand_INCLUDE_DIRS} ${hiprand_INCLUDE_DIRS} ${rocblas_INCLUDE_DIRS} ${miopen_INCLUDE_DIRS} ${thrust_INCLUDE_DIRS} $ ${Caffe2_HIP_INCLUDES})