Merge pull request #13 from RandomProgramm3r/develop

test: Add tests to the business app for creating promo codes.

- Add tests for creating promo codes, validating input data, and for permissions
- Separate tests into folders for future scaling
- Add several fields to PromoCreateSerializer for better input data validation

Author: RandomProgramm3r

.flake8

@@ -1,6 +1,6 @@
 [flake8]
 max-line-length = 79
-application_import_names = promo_code, user, core
+application_import_names = promo_code, user, core, business
 import-order-style = google
 exclude = */migrations/, venv/, verdict.py, .venv/,  env/, venv, .git, __pycache__
 max-complexity = 10

.isort.cfg

@@ -1,7 +1,7 @@
 [settings]
 profile = black
 skip = migrations, venv/, venv
-known_first_party = promo_code, user, core
+known_first_party = promo_code, user, core, business
 default_section = THIRDPARTY
 force_sort_within_sections = true
 line_length = 79

promo_code/business/permissions.py

@@ -1,6 +1,7 @@
-import business.models
 import rest_framework.permissions
 
+import business.models
+
 
 class IsCompanyUser(rest_framework.permissions.BasePermission):
     def has_permission(self, request, view):

promo_code/business/serializers.py

@@ -1,5 +1,3 @@
-import business.models as business_models
-import business.validators
 import django.contrib.auth.password_validation
 import django.core.exceptions
 import django.core.validators
@@ -12,6 +10,9 @@
 import rest_framework_simplejwt.tokens
 import rest_framework_simplejwt.views
 
+import business.models as business_models
+import business.validators
+
 
 class CompanySignUpSerializer(rest_framework.serializers.ModelSerializer):
     password = rest_framework.serializers.CharField(
@@ -147,6 +148,8 @@ class TargetSerializer(rest_framework.serializers.Serializer):
         allow_null=True,
     )
     country = rest_framework.serializers.CharField(
+        max_length=2,
+        min_length=2,
         required=False,
         allow_null=True,
         allow_blank=True,
@@ -173,7 +176,6 @@ def validate(self, data):
                 {'age_until': 'Must be greater than or equal to age_from.'},
             )
 
-        # change validation
         country = data.get('country')
         if country:
             country = country.strip().upper()
@@ -189,6 +191,18 @@ def validate(self, data):
 
 
 class PromoCreateSerializer(rest_framework.serializers.ModelSerializer):
+    description = rest_framework.serializers.CharField(
+        min_length=10,
+        max_length=300,
+        required=True,
+    )
+    image_url = rest_framework.serializers.CharField(
+        required=False,
+        max_length=350,
+        validators=[
+            django.core.validators.URLValidator(schemes=['http', 'https']),
+        ],
+    )
     target = TargetSerializer(required=True)
     promo_common = rest_framework.serializers.CharField(
         min_length=5,
@@ -220,10 +234,6 @@ class Meta:
             'promo_common',
             'promo_unique',
         )
-        extra_kwargs = {
-            'description': {'min_length': 10, 'max_length': 300},
-            'image_url': {'max_length': 350},
-        }
 
     def validate(self, data):
         mode = data.get('mode')

promo_code/business/tests/auth/base.py

@@ -1,9 +1,10 @@
-import business.models
 import django.urls
 import rest_framework
 import rest_framework.status
 import rest_framework.test
 
+import business.models
+
 
 class BaseBusinessAuthTestCase(rest_framework.test.APITestCase):
     @classmethod

promo_code/business/tests/auth/test_authentication.py

@@ -1,8 +1,9 @@
-import business.models
-import business.tests.auth.base
 import rest_framework.status
 import rest_framework.test
 
+import business.models
+import business.tests.auth.base
+
 
 class AuthenticationTests(business.tests.auth.base.BaseBusinessAuthTestCase):
     def test_signin_success(self):

promo_code/business/tests/auth/test_registration.py

@@ -1,8 +1,9 @@
-import business.models
-import business.tests.auth.base
 import rest_framework.status
 import rest_framework.test
 
+import business.models
+import business.tests.auth.base
+
 
 class TestCompanyRegistration(
     business.tests.auth.base.BaseBusinessAuthTestCase,

promo_code/business/tests/auth/test_tokens.py

@@ -1,9 +1,9 @@
-import business.models
-import business.tests.auth.base
 import rest_framework.status
 import rest_framework.test
 import rest_framework_simplejwt.tokens
 
+import business.models
+import business.tests.auth.base
 import user.models
 
 

promo_code/business/tests/auth/test_validation.py

@@ -1,9 +1,10 @@
-import business.models
-import business.tests.auth.base
 import parameterized
 import rest_framework.status
 import rest_framework.test
 
+import business.models
+import business.tests.auth.base
+
 
 class InvalidCompanyRegistrationTestCase(
     business.tests.auth.base.BaseBusinessAuthTestCase,