Skip to content

Commit b93cfda

Browse files
authored
Merge branch 'master' into dynamic_tooltip_content
2 parents 277633f + 3fac729 commit b93cfda

File tree

12 files changed

+3894
-187
lines changed

12 files changed

+3894
-187
lines changed

CHANGELOG.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
## Change Log
22

3-
### 3.4.1 (2018/04/05 17:15 +00:00)
3+
### 3.4.3 (2018/04/11 15:12 +00:00)
4+
- [#207](https://github.com/wwayne/react-tooltip/pull/207) Return tooltip to original position when possible (@hassanbot)
5+
- [#301](https://github.com/wwayne/react-tooltip/pull/301) insert css as first to allow easy css styling without important (@roblan)
6+
7+
### 3.4.2 (2018/04/09 18:58 +00:00)
8+
- [#373](https://github.com/wwayne/react-tooltip/pull/373) fix(example): 'made dev' works again, small fixes. (@aronhelser)
9+
- [#337](https://github.com/wwayne/react-tooltip/pull/337) Fix README show tip usage error (@gaohailang)
10+
- [#359](https://github.com/wwayne/react-tooltip/pull/359) License should use H2 as the previous sections do (@konekoya)
11+
12+
### 3.4.1 (2018/04/05 17:24 +00:00)
413
- [#369](https://github.com/wwayne/react-tooltip/pull/369) fix(index.js): add missing argument so tooltip hides. (@aronhelser)
514
- [#372](https://github.com/wwayne/react-tooltip/pull/372) Travis: update node version to fix travis build. (@aronhelser)
615

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,9 @@ Same for empty children, if you don't want show the tooltip when the children is
147147
## Article
148148
[How I insert sass into react component](https://medium.com/@wwayne_me/how-i-insert-sass-into-my-npm-react-component-b46b9811c226#.gi4hxu44a)
149149

150-
## Authors
151-
see [AUTHORS](https://github.com/wwayne/react-tooltip/blob/master/AUTHORS.txt)
150+
## Contributing
151+
152+
We welcome your contribution! Fork the repo, make some changes, submit a pull-request! Our [contributing](contributing.md) doc has some details.
152153

153154
## License
154155

contributing.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# Contributing
2+
3+
This doc needs help! Please submit your PR...
4+
5+
## Pull request testing
6+
7+
Some notes on testing and releasing.
8+
* For a PR, follow Github's command-line instructions for retrieving the branch with the changes.
9+
* `make dev` starts a development server, open `http://localhost:8888` to see the example website.
10+
* Provide feedback on the PR about your results.
11+
12+
## Doing a release
13+
14+
We really want to use semantic-release instead of this:
15+
16+
* `make deploy` updates the files in the `standalone` directory
17+
* update the version number in `package.json`
18+
- Fixes update the patch number, features update the minor number.
19+
- Major version update is reserved for API breaking changes, not just additions.
20+
* `npm run github-changes -- -n 3.X.Y` to update the changelog
21+
* `git add`, `git commit` and `git push` to get the version to master.
22+
* `git tag -a 3.X.Y -m 3.X.Y` `git push --tags`
23+
* `npm publish`
24+
* add a version on the github release page, based on the tag

example/src/index.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
'use strict'
22

3-
import React, { Component } from 'react'
4-
import {render, findDOMNode} from 'react-dom'
3+
import React from 'react'
4+
import ReactDOM from 'react-dom'
55
import ReactTooltip from '../../src'
66

7-
class Test extends Component {
7+
class Test extends React.Component {
88
constructor(props) {
99
super(props);
1010
this.state = {
@@ -157,8 +157,8 @@ class Test extends Component {
157157
<ReactTooltip id='custom-off-event'/>
158158
{/*
159159
<div>
160-
<button onClick={() => { ReactTooltip.show(findDOMNode(this.refs.target)) }}>Show toolip</button>
161-
<button onClick={() => { ReactTooltip.hide(findDOMNode(this.refs.target)) }}>Hide toolip</button>
160+
<button onClick={() => { ReactTooltip.show(ReactDOM.findDOMNode(this.refs.target)) }}>Show toolip</button>
161+
<button onClick={() => { ReactTooltip.hide(ReactDOM.findDOMNode(this.refs.target)) }}>Hide toolip</button>
162162
</div>
163163
*/}
164164
</div>
@@ -252,4 +252,4 @@ class Test extends Component {
252252
}
253253
}
254254

255-
render(<Test />, document.getElementById('main'))
255+
ReactDOM.render(<Test />, document.getElementById('main'))

0 commit comments

Comments
 (0)