Skip to content

[FEAT REQ] Deprecate the events prop in favor of a openOnClick prop #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrieljablonski opened this issue Feb 16, 2023 · 0 comments · Fixed by #979
Closed

[FEAT REQ] Deprecate the events prop in favor of a openOnClick prop #946

gabrieljablonski opened this issue Feb 16, 2023 · 0 comments · Fixed by #979

Comments

@gabrieljablonski
Copy link
Member

gabrieljablonski commented Feb 16, 2023

Is your feature request related to a problem? Please describe.
In previous versions, the click event worked in a way which made sense to have both hover and click enabled together (you could open on hover, and click on the anchor element to close). Since that behavior changed (clicking the tooltip always opens it, and clicking outside the anchor element closes it), having them both together doesn't do anything (hover takes precedence).

Describe the solution you'd like
We should deprecate the events prop and add a openOnClick (or some better name that is as clear as this) prop which can be effectively used to toggle between the hover and click events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant