should pass --noEmitHelpers to tsc when compiling

[prabirshrestha]

Currently the generated js code contains lot of duplicate __extends which can be seen here https://npmcdn.com/@reactivex/[email protected]/dist/global/Rx.umd.js

var __extends = (this && this.__extends) || function (d, b) {
    for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
    function __() { this.constructor = d; }
    d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
};

This should be avoided by using tsc --noEmitHelpers.

[kwonoj]

In case of babel, it also has similar option and requires to import common helper module on runtime. While typescript compiler option does not specifies detail (https://github.com/Microsoft/TypeScript/wiki/Compiler%20Options) it seems like works similar way - is that correct? At least by local tryout, giving noEmitHelper option makes cjs build throws

    __extends(Subscriber, _super);
    ^

ReferenceError: __extends is not defined
    at D:\github\RxJS\dist\cjs\Subscriber.js:7:5

that helper function is not imported.

[prabirshrestha]

Supporting external helpers library is part of TS v2.0 roadmap. https://github.com/Microsoft/TypeScript/wiki/Roadmap

Here are some of the issues discussing about it microsoft/TypeScript#2901, systemjs/builder#178, microsoft/TypeScript#3364

If using webpack you can use the imports-loader to fix the __extends issue. https://webpack.github.io/docs/shimming-modules.html#importing

Not sure about browserify. There could be something here https://github.com/thlorenz/browserify-shim.
Don't think it would be good to tell the user to define __extends as global var.

[kwonoj]

First, I don't think bundler can be considered as option since library should work out of box. For example, as noted above CJS module should work without any additional import, or bundling before any consumer start to use it.

Given aspect typescript compiler has plan to support it, I'd like to suggest to close issue this for now until those logistics are landed in compiler support. RxJS5 is living on leading-edge version of typescript (latest dev mostly) so once typescript dev branch adopt it as experimental, can try out quickly enough. What do you think @prabirshrestha ?

Also cc @Blesh before make decision to close out to have second opinion if there is.

disclaimer : personally I strongly prefer to remove duplication as original issue states, and appreciate to find out this is occurring on current codebase. My opinion is let's wait bit more to have environment / logistics to be more ready.

[prabirshrestha]

I'm ok for closing this issue and revisiting the issue when typescript official supports runtime libs.

I havent tried it with rx but when I tested with one of my internal libs, I noticed that when gzipping the size is almost the same whether there are multiple __extends or a single __extends.

[kwonoj]

Thanks for confirmation. I'll close this for now, and reopen once typescript is ready to track further details of how to deliver this into RxJS. Appreciate once again, @prabirshrestha

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.