Skip to content

Commit 8961b31

Browse files
authored
Enable AOF (#255)
* Enable AOF * Enable AOF in tests via env conf * Fix use of Env in tests. Run test suite multiple times with different env configurations. * Comment out panda test * Update pack version and license in RAMP file
1 parent 44d1c68 commit 8961b31

File tree

5 files changed

+102
-95
lines changed

5 files changed

+102
-95
lines changed

opt/Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,11 @@ ifneq ($(NO_LFS),1)
134134
endif
135135
$(SHOW)set -e ;\
136136
cd $(ROOT)/test ;\
137+
python3 -m RLTest $(TEST_ARGS) --test basic_tests.py --module $(INSTALL_DIR)/redisai.so ;\
137138
python3 -m RLTest $(TEST_ARGS) --test basic_tests.py --module $(INSTALL_DIR)/redisai.so --use-slaves ;\
138-
python3 -m RLTest $(TEST_ARGS) --test double-panda.py --module $(INSTALL_DIR)/redisai.so
139+
python3 -m RLTest $(TEST_ARGS) --test basic_tests.py --module $(INSTALL_DIR)/redisai.so --use-aof
140+
# Commented until the MacOS CI is available
141+
# python3 -m RLTest $(TEST_ARGS) --test double-panda.py --module $(INSTALL_DIR)/redisai.so
139142

140143
#----------------------------------------------------------------------------------------------
141144

ramp.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,18 @@ author: Orobix and RedisLabs
33
44
description: Serving tensors and executing deep learning graphs
55
homepage: https://oss.redislabs.com/redisai/
6-
license: GNU Affero General Public License v3.0
6+
license: Redis Source Available License v1.0
77
command_line_args: ""
88
min_redis_version: "5.0.7"
9-
min_redis_pack_version: "5.4"
9+
min_redis_pack_version: "5.4.11"
1010
capabilities:
1111
- types
1212
- no_multi_key
1313
- hash_policy
1414
- eviction_expiry
1515
- failover_migrate
1616
- persistence_rdb
17+
- persistence_aof
1718
- clustering
1819
exclude_commands:
1920
- ai.modelset

src/config.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,4 @@ typedef enum {
2222
#define RAI_COPY_RUN_OUTPUT
2323
#define RAI_PRINT_BACKEND_ERRORS
2424

25-
// #define RAI_OVERRIDE_AOF_CHECK
26-
2725
#endif /* SRC_CONFIG_H_ */

src/redisai.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1486,12 +1486,6 @@ int RedisModule_OnLoad(RedisModuleCtx *ctx, RedisModuleString **argv, int argc)
14861486
== REDISMODULE_ERR) return REDISMODULE_ERR;
14871487

14881488
int flags = RedisModule_GetContextFlags(ctx);
1489-
if (flags & REDISMODULE_CTX_FLAGS_AOF) {
1490-
RedisModule_Log(ctx, "warning", "ERR: AOF currently unsupported\r\n");
1491-
#ifndef RAI_OVERRIDE_AOF_CHECK
1492-
return REDISMODULE_ERR;
1493-
#endif
1494-
}
14951489

14961490
RAI_BackendsPath = NULL;
14971491

0 commit comments

Comments
 (0)