Skip to content

Changes pushed to master without a Pull Request #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vladimir-ch opened this issue Nov 27, 2019 · 2 comments
Closed

Changes pushed to master without a Pull Request #371

vladimir-ch opened this issue Nov 27, 2019 · 2 comments

Comments

@vladimir-ch
Copy link
Contributor

This is not an issue with the reference lapack per se, rather a suggestion or a mild request towards its maintainers.

It seems that the project allows to push changes directly to master without going first through a pull request. Consequently changes silently land in master without any notification even for people watching the repository which makes it harder to follow the work that is being done. This has happened recently for example with the dorhr addition. I perfectly understand that this style may fit the contributors workflow but could the maintainers at least consider protecting master so that "... all commits must be made to a non-protected branch and submitted via a pull request with the required number of approving reviews ..."? This can be easily done via Settings -> Branches -> Branch protection rules.

@thijssteel
Copy link
Collaborator

I saw that this happened again the last few days. Pushing finished pieces of code received via mail to master without a PR is acceptable, but just working on the master branch... breaking the master branch in a massively used repo like this seems like a recipe for disaster.

@julielangou
Copy link
Contributor

Thank you for the advice.
We just added a branch rule on our repository to not allow direct commit into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants