Skip to content

LAPACKE interfaces and C prototypes for ?GEDMD(Q) do not match the implementation #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 2 tasks
martin-frbg opened this issue Jul 9, 2023 · 0 comments · Fixed by #880
Closed
1 of 2 tasks

Comments

@martin-frbg
Copy link
Collaborator

Description
While looking into a reported LTO type mismatch problem in OpenBLAS, I have found that the LAPACKE interfaces for the
Dynamic Mode Decomposition functions recently added in #736 appear to be completely bogus - probably being based on
an earlier draft of the implementation. (Missing JOBR and ZWORK/LZWORK parameters, wrong type declaration for WORK array, EIGS split into separate complex arrays for the real and imaginary component - even for the S,D forms).
In addition, the corresponding prototypes in the C headers lack the hidden arguments for LAPACK_STRLEN_END
Working on a PR
Checklist

  • I've included a minimal example to reproduce the issue
  • I'd be willing to make a PR to solve this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant