Skip to content

Commit 36225a7

Browse files
Yang Yinglianggregkh
Yang Yingliang
authored andcommitted
w1: fix WARNING after calling w1_process()
I got the following WARNING message while removing driver(ds2482): ------------[ cut here ]------------ do not call blocking ops when !TASK_RUNNING; state=1 set at [<000000002d50bfb6>] w1_process+0x9e/0x1d0 [wire] WARNING: CPU: 0 PID: 262 at kernel/sched/core.c:9817 __might_sleep+0x98/0xa0 CPU: 0 PID: 262 Comm: w1_bus_master1 Tainted: G N 6.1.0-rc3+ #307 RIP: 0010:__might_sleep+0x98/0xa0 Call Trace: exit_signals+0x6c/0x550 do_exit+0x2b4/0x17e0 kthread_exit+0x52/0x60 kthread+0x16d/0x1e0 ret_from_fork+0x1f/0x30 The state of task is set to TASK_INTERRUPTIBLE in loop in w1_process(), set it to TASK_RUNNING when it breaks out of the loop to avoid the warning. Fixes: 3c52e4e ("W1: w1_process, block or sleep") Signed-off-by: Yang Yingliang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 25d5648 commit 36225a7

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/w1/w1.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1195,8 +1195,10 @@ int w1_process(void *data)
11951195
*/
11961196
mutex_unlock(&dev->list_mutex);
11971197

1198-
if (kthread_should_stop())
1198+
if (kthread_should_stop()) {
1199+
__set_current_state(TASK_RUNNING);
11991200
break;
1201+
}
12001202

12011203
/* Only sleep when the search is active. */
12021204
if (dev->search_count) {

0 commit comments

Comments
 (0)