Skip to content

JSON $schema #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albertmink opened this issue Mar 24, 2021 · 5 comments
Closed

JSON $schema #14

albertmink opened this issue Mar 24, 2021 · 5 comments

Comments

@albertmink
Copy link
Contributor

We have to clarify what $schema we are refering to in the serialized files:

See:
#11 (comment)

@schneidermic0
Copy link
Contributor

Now, I have got your point. This is a good question. I guess we should start with the second one. Any further opinions?

@Christopher-Hermann
Copy link
Contributor

I also prefer the second approach.

@xtough
Copy link
Contributor

xtough commented Mar 26, 2021

Neither the 1st, nor the 2nd approach.
1st is obviously not a valid URL, it will always yield 404.
2nd is a moving target, because blob/main may change from one minute to the next.
At least for instances of these JSON Schemas, I would prefer a stable URL like https://github.com/SAP/abap-file-formats/release/1.2.3/file-formats/clas/clas.json and for the schema ID itself something like https://github.com/SAP/abap-file-formats/release/latest/file-formats/clas/clas.json
We should look into GitHub Tags and Releases at https://docs.github.com/en/github/administering-a-repository/linking-to-releases

@albertmink
Copy link
Contributor Author

Good input and yes, we should avoid using moving targets 😅

So, once there is a release/tag release_v.1, we can use
https://github.com/SAP/abap-file-formats/blob/release_v.1/file-formats/clas/clas.json
instead the blob/main.

@albertmink
Copy link
Contributor Author

Once we have published the repo, urls like
https://github.com/raw/SAP/abap-file-formats/main/file-formats/clas/clas.json
would work and open the file as it is. Tagging by release/tag is preserved.
To me, this seams like the natural choice.

@albertmink albertmink mentioned this issue Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants