Skip to content

Incompatibility with abapGit after commit dc4b3705216757c7533f5802d51 #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ConjuringCoffee opened this issue Nov 10, 2021 · 1 comment · Fixed by #530 or #529
Closed

Incompatibility with abapGit after commit dc4b3705216757c7533f5802d51 #528

ConjuringCoffee opened this issue Nov 10, 2021 · 1 comment · Fixed by #530 or #529
Assignees
@lucasborin
Labels
bug Something isn't working correctly

Comments

@ConjuringCoffee
Copy link
Contributor

In abapGit, the variable zif_abapgit_version=>gc_abap_version was changed to zif_abapgit_version=>c_abap_version.

This was done in commit dc4b3705216757c7533f5802d51.
The change causes a syntax error in method EXECUTE_GET_VERSIONS in Y_CODE_PAL_SERVICE.
@ConjuringCoffee ConjuringCoffee added the bug Something isn't working correctly label Nov 10, 2021
@ConjuringCoffee
Copy link
Contributor Author

Will be made obsolete if dependency to abapGit is removed in #524

@lucasborin lucasborin self-assigned this Nov 11, 2021
This was linked to pull requests Nov 11, 2021
Removing Service #530
Merged
1.16.3 #529
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasborin lucasborin

Labels
bug Something isn't working correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removing Service SAP/code-pal-for-abap
1.16.3 SAP/code-pal-for-abap
2 participants
@lucasborin @ConjuringCoffee