Skip to content

Commit a331ad0

Browse files
committed
Remove deprecated uses of UIActivityIndicatorViewStyle (facebook#38208)
Summary: Super simple change to replace some deprecated ENUM values with the correct one, now that we're on iOS 13.0+. From `UIActivityIndicator.h`: ``` typedef NS_ENUM(NSInteger, UIActivityIndicatorViewStyle) { UIActivityIndicatorViewStyleMedium API_AVAILABLE(ios(13.0), tvos(13.0)) = 100, UIActivityIndicatorViewStyleLarge API_AVAILABLE(ios(13.0), tvos(13.0)) = 101, UIActivityIndicatorViewStyleWhiteLarge API_DEPRECATED_WITH_REPLACEMENT("UIActivityIndicatorViewStyleLarge", ios(2.0, 13.0), tvos(9.0, 13.0)) = 0, UIActivityIndicatorViewStyleWhite API_DEPRECATED_WITH_REPLACEMENT("UIActivityIndicatorViewStyleMedium", ios(2.0, 13.0), tvos(9.0, 13.0)) = 1, UIActivityIndicatorViewStyleGray API_DEPRECATED_WITH_REPLACEMENT("UIActivityIndicatorViewStyleMedium", ios(2.0, 13.0)) API_UNAVAILABLE(tvos) = 2, }; ``` ## Changelog: [IOS] [CHANGED] - Remove deprecated uses of UIActivityIndicatorViewStyle Pull Request resolved: facebook#38208 Test Plan: CI should pass Reviewed By: cipolleschi Differential Revision: D47254035 Pulled By: rshest fbshipit-source-id: 6d3270899e8d52611d91c777f324c3c6f0c520be
1 parent 7119f0e commit a331ad0

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/react-native/React/Fabric/Mounting/ComponentViews/ActivityIndicator/RCTActivityIndicatorViewComponentView.mm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ static UIActivityIndicatorViewStyle convertActivityIndicatorViewStyle(const Acti
2222
{
2323
switch (size) {
2424
case ActivityIndicatorViewSize::Small:
25-
return UIActivityIndicatorViewStyleWhite;
25+
return UIActivityIndicatorViewStyleMedium;
2626
case ActivityIndicatorViewSize::Large:
27-
return UIActivityIndicatorViewStyleWhiteLarge;
27+
return UIActivityIndicatorViewStyleLarge;
2828
}
2929
}
3030

packages/react-native/React/Views/RCTActivityIndicatorViewManager.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ @implementation RCTConvert (UIActivityIndicatorView)
1818
RCT_ENUM_CONVERTER(
1919
UIActivityIndicatorViewStyle,
2020
(@{
21-
@"large" : @(UIActivityIndicatorViewStyleWhiteLarge),
22-
@"small" : @(UIActivityIndicatorViewStyleWhite),
21+
@"large" : @(UIActivityIndicatorViewStyleLarge),
22+
@"small" : @(UIActivityIndicatorViewStyleMedium),
2323
}),
24-
UIActivityIndicatorViewStyleWhiteLarge,
24+
UIActivityIndicatorViewStyleLarge,
2525
integerValue)
2626

2727
@end

0 commit comments

Comments
 (0)