Copy parameter object before setting in subset_tunables
#3922
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AayushSabharwal
approved these changes
Sep 17, 2025
AayushSabharwal
requested changes
Sep 17, 2025
|
Added the test |
|
https://github.com/SciML/ModelingToolkit.jl/actions/runs/17833787809/job/50705498058?pr=3922#step:6:997 seems like IDA failing initialization (because it runs overrideinit now). If it's easy, could you patch that? InterfaceI being red is really not great. |
|
Agreed re failing CI, but that might be out of scope a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
closes #3921
cc @AayushSabharwal @SebastianM-C @ChrisRackauckas
Add any other context about the problem here.