Merge pull request #205 from SciML/sa

Require ArrayInterfaceStaticArrays to fix downstream

Author: ChrisRackauckas

Project.toml

@@ -6,6 +6,7 @@ version = "2.28.0"
 [deps]
 Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
 ArrayInterfaceCore = "30b0a656-2188-435a-8636-2ec0e6a096e2"
+ArrayInterfaceStaticArrays = "b0d46f97-bff5-4637-a19a-dd75974142cd"
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
 DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
 FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"
@@ -19,6 +20,7 @@ ZygoteRules = "700de1a5-db45-46bc-99cf-38207098b444"
 [compat]
 Adapt = "3"
 ArrayInterfaceCore = "0.1.1"
+ArrayInterfaceStaticArrays = "0.1"
 ChainRulesCore = "0.10.7, 1"
 DocStringExtensions = "0.8"
 FillArrays = "0.11, 0.12, 0.13"

src/RecursiveArrayTools.jl

@@ -12,6 +12,11 @@ import ChainRulesCore
 import ChainRulesCore: NoTangent
 import ZygoteRules, Adapt
 
+# Required for the downstream_events.jl test
+# Since `ismutable` on an ArrayPartition needs
+# to know static arrays are not mutable
+import ArrayInterfaceStaticArrays
+
 using FillArrays
 
 abstract type AbstractVectorOfArray{T, N, A} <: AbstractArray{T, N} end

test/downstream/downstream_events.jl

@@ -0,0 +1,18 @@
+using OrdinaryDiffEq, StaticArrays, RecursiveArrayTools
+u0 = ArrayPartition(SVector{1}(50.0), SVector{1}(0.0))
+tspan = (0.0,15.0)
+
+function f(u,p,t)
+    ArrayPartition(SVector{1}(u[2]), SVector{1}(-9.81))
+end
+
+prob = ODEProblem(f,u0,tspan)
+
+affect! = nothingf =
+affect_neg! = function (integrator)
+  integrator.u = ArrayPartition(SVector{1}(integrator.u[1]), SVector{1}(-integrator.u[2]))
+end
+
+callback = ContinuousCallback(condition,affect!,affect_neg!,interp_points=100)
+
+sol = solve(prob,Tsit5(),callback=callback,adaptive=false,dt=1/4)

test/runtests.jl

@@ -33,6 +33,7 @@ end
 if !is_APPVEYOR && GROUP == "Downstream"
   activate_downstream_env()
   @time @testset "DiffEqArray Indexing Tests" begin include("downstream/symbol_indexing.jl") end
+  @time @testset "Event Tests with ArrayPartition" begin include("downstream/downstream_events.jl") end
 end
 
 if !is_APPVEYOR && GROUP == "GPU"