-
Notifications
You must be signed in to change notification settings - Fork 295
Proposed fixes to _discontiguity_in_bounds() #3480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See #3345 |
Peloton discussion - this passes for meshes that are contiguous, but fails to recognise some meshes that aren't contiguous. |
@stephenworsley Is this important for |
I've had another look at my comments for this and I believe there is also another bug which would cause discontiguous coords to test as contiguous due to these lines: Lines 1978 to 1984 in ae2b59b
which would fail when cell_size was sufficiently large.
|
In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity. If this issue is still important to you, then please comment on this issue and the stale label will be removed. Otherwise this issue will be automatically closed in 28 days time. |
This stale issue has been automatically closed due to a lack of community activity. If you still care about this issue, then please either:
|
@stephenworsley Reference #3404
Let's have the discussion here, and see if there is any momentum.
@pp-mo and @alastair-gemmell
The text was updated successfully, but these errors were encountered: