Skip to content

Proposed fixes to _discontiguity_in_bounds() #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bjlittle opened this issue Oct 22, 2019 · 6 comments
Closed

Proposed fixes to _discontiguity_in_bounds() #3480

bjlittle opened this issue Oct 22, 2019 · 6 comments
Labels
Stale A stale issue/pull-request Type: Question

Comments

@bjlittle
Copy link
Member

@stephenworsley Reference #3404

Let's have the discussion here, and see if there is any momentum.

@pp-mo and @alastair-gemmell

@cpelley
Copy link

cpelley commented Jan 22, 2020

See #3345

@bjlittle
Copy link
Member Author

Peloton discussion - this passes for meshes that are contiguous, but fails to recognise some meshes that aren't contiguous.

@bjlittle
Copy link
Member Author

@stephenworsley Is this important for iris-esmf-regrid ?

@stephenworsley
Copy link
Contributor

Peloton discussion - this passes for meshes that are contiguous, but fails to recognise some meshes that aren't contiguous.

I've had another look at my comments for this and I believe there is also another bug which would cause discontiguous coords to test as contiguous due to these lines:

iris/lib/iris/coords.py

Lines 1978 to 1984 in ae2b59b

diffs_along_axis = diffs_between_cells > (
atol + rtol * cell_size
)
points_close_enough = diffs_along_axis <= (
atol + rtol * cell_size
)

which would fail when cell_size was sufficiently large.

Copy link
Contributor

github-actions bot commented Feb 4, 2024

In order to maintain a backlog of relevant issues, we automatically label them as stale after 500 days of inactivity.

If this issue is still important to you, then please comment on this issue and the stale label will be removed.

Otherwise this issue will be automatically closed in 28 days time.

@github-actions github-actions bot added the Stale A stale issue/pull-request label Feb 4, 2024
Copy link
Contributor

github-actions bot commented Mar 4, 2024

This stale issue has been automatically closed due to a lack of community activity.

If you still care about this issue, then please either:

  • Re-open this issue, if you have sufficient permissions, or
  • Add a comment stating that this is still relevant and someone will re-open it on your behalf.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
@scitools-ci scitools-ci bot removed this from 🚴 Peloton Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale A stale issue/pull-request Type: Question
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants