Skip to content

Commit 54b4942

Browse files
committed
#14 duplicate truncation of models
1 parent 523dfa0 commit 54b4942

File tree

4 files changed

+23
-30
lines changed

4 files changed

+23
-30
lines changed

app/code/community/LeMike/DevMode/Helper/Data.php

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,18 @@ protected function _getStoreId()
4343

4444
return $this->_storeId;
4545
}
46+
47+
48+
public function truncateModel($model)
49+
{
50+
$processed = 0;
51+
foreach ($model as $entry)
52+
{
53+
$entry = $entry->load($entry->getId());
54+
$entry->delete();
55+
$processed++;
56+
}
57+
58+
return $processed;
59+
}
4660
}

app/code/community/LeMike/DevMode/controllers/Adminhtml/Developer/Catalog/ProductsController.php

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,9 @@ public function deleteAllAction()
3636
'errors' => array(),
3737
);
3838

39-
$productSet = $this->_getProductSet();
40-
$deleteAll['amount'] = $productSet->count();
41-
42-
foreach ($productSet as $product)
43-
{
44-
$product = $product->load($product->getId());
45-
/** @var Mage_Catalog_Model_Product $product */
46-
$product->delete();
47-
$deleteAll['processed']++;
48-
}
39+
$productSet = $this->_getProductSet();
40+
$deleteAll['amount'] = $productSet->count();
41+
$deleteAll['processed'] = Mage::helper('lemike_devmode')->truncateModel($productSet);
4942

5043
$this->_responseJson($deleteAll);
5144
}

app/code/community/LeMike/DevMode/controllers/Adminhtml/Developer/Customer/CustomerController.php

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,9 @@ public function deleteAllAction()
3636
'errors' => array(),
3737
);
3838

39-
$set = $this->_getSet();
40-
$deleteAll['amount'] = $set->count();
41-
42-
foreach ($set as $item)
43-
{
44-
/** @var Mage_Sales_Model_Order $item */
45-
$item = $item->load($item->getId());
46-
$item->delete();
47-
$deleteAll['processed']++;
48-
}
39+
$set = $this->_getSet();
40+
$deleteAll['amount'] = $set->count();
41+
$deleteAll['processed'] = Mage::helper('lemike_devmode')->truncateModel($set);
4942

5043
$this->_responseJson($deleteAll);
5144
}

app/code/community/LeMike/DevMode/controllers/Adminhtml/Developer/Sales/OrderController.php

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,9 @@ public function deleteAllAction()
3636
'errors' => array(),
3737
);
3838

39-
$orderSet = $this->_getOrderSet();
40-
$deleteAll['amount'] = $orderSet->count();
41-
42-
foreach ($orderSet as $order)
43-
{
44-
/** @var Mage_Sales_Model_Order $order */
45-
$order = $order->load($order->getId());
46-
$order->delete();
47-
$deleteAll['processed']++;
48-
}
39+
$orderSet = $this->_getOrderSet();
40+
$deleteAll['amount'] = $orderSet->count();
41+
$deleteAll['processed'] = Mage::helper('lemike_devmode')->truncateModel($orderSet);
4942

5043
$this->_responseJson($deleteAll);
5144
}

0 commit comments

Comments
 (0)