Skip to content

Commit 5b29bae

Browse files
committed
#14 duplicate code: json response
1 parent c3464ff commit 5b29bae

File tree

4 files changed

+26
-46
lines changed

4 files changed

+26
-46
lines changed

app/code/community/LeMike/DevMode/Helper/Data.php

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,17 @@ public function truncateModel($model)
4646

4747
return $processed;
4848
}
49+
50+
51+
/**
52+
* .
53+
*
54+
* @param array $data
55+
* @return void
56+
*/
57+
public function responseJson($data)
58+
{
59+
$this->getResponse()->setHeader('Content-type', 'application/json');
60+
$this->getResponse()->setBody(Zend_Json_Encoder::encode($data));
61+
}
4962
}

app/code/community/LeMike/DevMode/controllers/Adminhtml/Developer/Catalog/ProductsController.php

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,13 @@ public function deleteAllAction()
3636
'errors' => array(),
3737
);
3838

39+
$helper = Mage::helper('lemike_devmode');
40+
3941
$productSet = $this->_getProductSet();
4042
$deleteAll['amount'] = $productSet->count();
41-
$deleteAll['processed'] = Mage::helper('lemike_devmode')->truncateModel($productSet);
43+
$deleteAll['processed'] = $helper->truncateModel($productSet);
4244

43-
$this->_responseJson($deleteAll);
45+
$helper->responseJson($deleteAll);
4446
}
4547

4648

@@ -83,7 +85,7 @@ public function sanitizeAllAction()
8385
}
8486
}
8587

86-
$this->_responseJson($sanitizeAll);
88+
Mage::helper('lemike_devmode')->responseJson($sanitizeAll);
8789
}
8890

8991

@@ -105,17 +107,4 @@ protected function _getProductSet()
105107

106108
return $productSet;
107109
}
108-
109-
110-
/**
111-
* .
112-
*
113-
* @param $data
114-
* @return void
115-
*/
116-
protected function _responseJson($data)
117-
{
118-
$this->getResponse()->setHeader('Content-type', 'application/json');
119-
$this->getResponse()->setBody(Zend_Json_Encoder::encode($data));
120-
}
121110
}

app/code/community/LeMike/DevMode/controllers/Adminhtml/Developer/Customer/CustomerController.php

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,13 @@ public function deleteAllAction()
3636
'errors' => array(),
3737
);
3838

39+
$helper = Mage::helper('lemike_devmode');
40+
3941
$set = $this->_getSet();
4042
$deleteAll['amount'] = $set->count();
41-
$deleteAll['processed'] = Mage::helper('lemike_devmode')->truncateModel($set);
43+
$deleteAll['processed'] = $helper->truncateModel($set);
4244

43-
$this->_responseJson($deleteAll);
45+
$helper->responseJson($deleteAll);
4446
}
4547

4648

@@ -56,17 +58,4 @@ protected function _getSet()
5658

5759
return Mage::getModel('customer/customer')->getCollection();
5860
}
59-
60-
61-
/**
62-
* .
63-
*
64-
* @param $data
65-
* @return void
66-
*/
67-
protected function _responseJson($data)
68-
{
69-
$this->getResponse()->setHeader('Content-type', 'application/json');
70-
$this->getResponse()->setBody(Zend_Json_Encoder::encode($data));
71-
}
7261
}

app/code/community/LeMike/DevMode/controllers/Adminhtml/Developer/Sales/OrderController.php

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,13 @@ public function deleteAllAction()
3636
'errors' => array(),
3737
);
3838

39+
$helper = Mage::helper('lemike_devmode');
40+
3941
$orderSet = $this->_getOrderSet();
4042
$deleteAll['amount'] = $orderSet->count();
41-
$deleteAll['processed'] = Mage::helper('lemike_devmode')->truncateModel($orderSet);
43+
$deleteAll['processed'] = $helper->truncateModel($orderSet);
4244

43-
$this->_responseJson($deleteAll);
45+
$helper->responseJson($deleteAll);
4446
}
4547

4648

@@ -56,17 +58,4 @@ protected function _getOrderSet()
5658

5759
return Mage::getModel('sales/order')->getCollection();
5860
}
59-
60-
61-
/**
62-
* .
63-
*
64-
* @param $data
65-
* @return void
66-
*/
67-
protected function _responseJson($data)
68-
{
69-
$this->getResponse()->setHeader('Content-type', 'application/json');
70-
$this->getResponse()->setBody(Zend_Json_Encoder::encode($data));
71-
}
7261
}

0 commit comments

Comments
 (0)