#14 Code Assertions

Author: ScreamingDev

app/code/community/LeMike/DevMode/Model/Observer.php

@@ -69,7 +69,7 @@ public function controllerFrontSendResponseBefore($observer)
             $value = $reflectEventCache->getValue(Mage::app());
 
             $returnSet = array();
-            foreach ($value as $area => $eventSet)
+            foreach ($value as $eventSet)
             {
                 $returnSet = array_merge($returnSet, array_keys($eventSet));
             }

app/code/community/LeMike/DevMode/Test/Model/EmailTest.php

@@ -56,7 +56,7 @@ public function testRewrite()
      */
     public function testFixtureConfig()
     {
-        $this->assertFalse(Mage::helper('lemike_devmode/config')->isMailAllowed());
+        $this->assertFalse((bool)Mage::helper('lemike_devmode/config')->isMailAllowed());
     }
 
 

app/code/community/LeMike/DevMode/controllers/Adminhtml/Developer/Catalog/ProductsController.php

@@ -117,7 +117,7 @@ protected function _getProductSet()
     /**
      * .
      *
-     * @param $deleteAll
+     * @param $data
      * @return void
      */
     protected function _responseJson($data)

app/code/community/LeMike/DevMode/controllers/Adminhtml/Developer/Customer/CustomerController.php

@@ -68,7 +68,7 @@ protected function _getSet()
     /**
      * .
      *
-     * @param $deleteAll
+     * @param $data
      * @return void
      */
     protected function _responseJson($data)

app/code/community/LeMike/DevMode/controllers/Adminhtml/Developer/Sales/OrderController.php

@@ -68,7 +68,7 @@ protected function _getOrderSet()
     /**
      * .
      *
-     * @param $deleteAll
+     * @param $data
      * @return void
      */
     protected function _responseJson($data)

app/design/adminhtml/default/default/layout/LeMike_DevMode.xml

@@ -4,7 +4,7 @@
         <reference name="notifications">
             <block type="adminhtml/template" name="lemike.devmode.notifications"
                    template="lemike/devmode/notifications.phtml"
-                   before="-"></block>
+                   before="-"/>
         </reference>
     </default>
 
@@ -18,7 +18,7 @@
     <adminhtml_developer_catalog_index>
         <reference name="js">
             <block type="adminhtml/template" template="lemike/devmode/catalog/js.phtml"
-                   name="lemike.devmode.catalog.product.js" as="product_js"></block>
+                   name="lemike.devmode.catalog.product.js" as="product_js"/>
         </reference>
         <reference name="left">
             <block type="lemike_devmode/catalog_tabs" name="lemike.devmode.catalog.tabs"/>
@@ -32,7 +32,7 @@
     <adminhtml_developer_sales_index>
         <reference name="js">
             <block type="adminhtml/template" template="lemike/devmode/sales/js.phtml"
-                   name="lemike.devmode.sales.js" as="sales_js"></block>
+                   name="lemike.devmode.sales.js" as="sales_js"/>
         </reference>
         <reference name="left">
             <block type="lemike_devmode/sales_tabs" name="lemike.devmode.sales.tabs"/>
@@ -46,7 +46,7 @@
     <adminhtml_developer_customer_index>
         <reference name="js">
             <block type="adminhtml/template" template="lemike/devmode/customer/js.phtml"
-                   name="customer.js" as="customer_js"></block>
+                   name="customer.js" as="customer_js"/>
         </reference>
         <reference name="left">
             <block type="lemike_devmode/customer_tabs" name="customer.tabs"/>
@@ -60,7 +60,7 @@
     <adminhtml_developer_core_index>
         <reference name="js">
             <block type="adminhtml/template" template="lemike/devmode/core/js.phtml"
-                   name="core.js" as="core_js"></block>
+                   name="core.js" as="core_js"/>
         </reference>
         <reference name="left">
             <block type="lemike_devmode/core_tabs" name="core.tabs"/>

app/design/adminhtml/default/default/template/lemike/devmode/about.phtml

@@ -9,7 +9,7 @@
     </p>
 
     <p>
-        Warning! This extension is only ment for development and can be a security issue when using it in your online
+        Warning! This extension is only meant for development and can be a security issue when using it in your online
         / live / productive shop.
     </p>
 

shell/dev/adminPassword.php

@@ -30,7 +30,7 @@ function prompt_silent($prompt = "Enter Password: ")
             {
                 trigger_error("Can't invoke bash");
 
-                return;
+                return null;
             }
             $command  = "/usr/bin/env bash -c 'read -s -p \""
                         . addslashes($prompt)