Skip to content

Commit 40529f9

Browse files
committed
Deprecated response header action
1 parent d0bddb9 commit 40529f9

File tree

3 files changed

+4
-23
lines changed

3 files changed

+4
-23
lines changed

FroniusSolarClient.Examples/Program.cs

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,6 @@ namespace FroniusSolarClient.Examples
88
{
99
class Program
1010
{
11-
12-
/// <summary>
13-
/// Prints out the status of the last response header
14-
/// </summary>
15-
/// <param name="responseHeader"></param>
16-
static void OutputResponseHeader(CommonResponseHeader responseHeader, ILogger logger)
17-
{
18-
logger.LogInformation($"Response Header Status - {responseHeader.Status.Code} at {responseHeader.Timestamp}");
19-
}
20-
2111
static void Main(string[] args)
2212
{
2313
// Configure logger
@@ -26,7 +16,7 @@ static void Main(string[] args)
2616
.Configure<LoggerFilterOptions>(opt => opt.MinLevel = LogLevel.Debug)
2717
.BuildServiceProvider();
2818

29-
var client = new SolarClient("10.1.1.124", 1, serviceProvider.GetService<ILogger<SolarClient>>(), OutputResponseHeader);
19+
var client = new SolarClient("10.1.1.124", 1, serviceProvider.GetService<ILogger<SolarClient>>());
3020

3121
//GetArchiveDataOverPast24Hours(client);
3222
GetRealTimeData(client);

FroniusSolarClient/RestClient.cs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,24 +11,18 @@ namespace FroniusSolarClient
1111
/// </summary>
1212
internal class RestClient
1313
{
14-
1514
private readonly HttpClient _httpClient;
1615
private readonly string _url;
1716
private readonly ILogger _logger;
18-
/// <summary>
19-
/// This action delegate provides access to the response headers
20-
/// </summary>
21-
private Action<CommonResponseHeader, ILogger> _commonResponseHeader;
2217

23-
public RestClient(HttpClient httpClient, string url, Action<CommonResponseHeader, ILogger> commonResponseHeader, ILogger logger)
18+
public RestClient(HttpClient httpClient, string url, ILogger logger)
2419
{
2520
if (String.IsNullOrEmpty(url))
2621
throw new ArgumentException("URL not specified");
2722

2823
this._httpClient = httpClient ?? new HttpClient();
2924
this._url = url;
3025

31-
_commonResponseHeader = commonResponseHeader;
3226
_logger = logger;
3327
}
3428

@@ -68,9 +62,6 @@ public Response<T> GetResponse<T>(string endpoint)
6862

6963
var response = JsonHelper.DeSerializeResponse<Response<T>>(content);
7064

71-
if (_commonResponseHeader != null)
72-
_commonResponseHeader.Invoke(response.Head, _logger);
73-
7465
return response;
7566
}
7667
catch (System.Exception ex)

FroniusSolarClient/SolarClient.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ public class SolarClient
2020
private InverterRealtimeDataService _inverterRealtimeDataService;
2121
private InverterArchiveDataService _inverterArchiveDataService;
2222

23-
public SolarClient(string url, int version, ILogger logger, Action<CommonResponseHeader, ILogger> commonResponseHeader = null)
23+
public SolarClient(string url, int version, ILogger logger)
2424
{
2525
_configuration = new SolarClientConfiguration(url, version);
26-
_restClient = new RestClient(null, _configuration.GetBaseURL(), commonResponseHeader, logger);
26+
_restClient = new RestClient(null, _configuration.GetBaseURL(), logger);
2727

2828

2929
_inverterRealtimeDataService = new InverterRealtimeDataService(_restClient);

0 commit comments

Comments
 (0)