CPP-413 - Enable client-side timestamps by default (datastax#195)

Author: mpenick

cpp-driver/include/cassandra.h

@@ -2335,7 +2335,7 @@ cass_cluster_set_tcp_keepalive(CassCluster* cluster,
  * Sets the timestamp generator used to assign timestamps to all requests
  * unless overridden by setting the timestamp on a statement or a batch.
  *
- * <b>Default:</b> server-side timestamp generator.
+ * <b>Default:</b> Monotonically increasing, client-side timestamp generator.
  *
  * @cassandra{2.1+}
  *
@@ -10533,7 +10533,7 @@ cass_timestamp_gen_monotonic_new();
  * @param warning_threshold_us The amount of clock skew, in microseconds, that
  * must be detected before a warning is triggered. A threshold less than 0 can
  * be used to disable warnings.
- * @param warning_interval_ms The amount of time, in milliseonds, to wait before
+ * @param warning_interval_ms The amount of time, in milliseconds, to wait before
  * warning again about clock skew. An interval value less than or equal to 0 allows
  * the warning to be triggered every millisecond.
  * @return Returns a timestamp generator that must be freed.

cpp-driver/src/config.hpp

@@ -57,7 +57,7 @@ class Config {
       , tcp_keepalive_delay_secs_(CASS_DEFAULT_TCP_KEEPALIVE_DELAY_SECS)
       , connection_idle_timeout_secs_(CASS_DEFAULT_IDLE_TIMEOUT_SECS)
       , connection_heartbeat_interval_secs_(CASS_DEFAULT_HEARTBEAT_INTERVAL_SECS)
-      , timestamp_gen_(Memory::allocate<ServerSideTimestampGenerator>())
+      , timestamp_gen_(Memory::allocate<MonotonicTimestampGenerator>())
       , use_schema_(CASS_DEFAULT_USE_SCHEMA)
       , use_hostname_resolution_(CASS_DEFAULT_HOSTNAME_RESOLUTION_ENABLED)
       , use_randomized_contact_points_(CASS_DEFAULT_USE_RANDOMIZED_CONTACT_POINTS)

cpp-driver/test/integration_tests/src/test_timestamps.cpp

@@ -240,10 +240,10 @@ BOOST_AUTO_TEST_CASE(generator)
 }
 
 /**
- * Test the default timestamp generator.
+ * Test the server-side generator.
  *
- * Verifies that the timestamp is set by the server when no timestamp
- * generator is set and the timestamp is not set directly on the statement.
+ * Verifies that the timestamp is set by the server when using the server-side
+ * generator and the timestamp is not set directly on the statement.
  *
  * @since 2.1.0
  * @jira_ticket CPP-266
@@ -255,6 +255,9 @@ BOOST_AUTO_TEST_CASE(server_side)
   CCM::CassVersion version = test_utils::get_version();
   if ((version.major_version >= 2 && version.minor_version >= 1) || version.major_version >= 3) {
     TimestampsTest tester;
+    CassTimestampGen* gen = cass_timestamp_gen_server_side_new();
+    cass_cluster_set_timestamp_gen(tester.cluster, gen);
+    cass_timestamp_gen_free(gen);
     tester.create_session();
     // Server-side is the default timestamp generator
     std::string table_name("table_" + test_utils::generate_unique_str(tester.uuid_gen));

cpp-driver/topics/basics/client_side_timestamps/README.md

@@ -4,8 +4,8 @@
 
 Cassandra uses timestamps to serialize write operations. That is, values with a
 more current timestamp are considered to be the most up-to-date version of that
-information. By default, timestamps are assigned by Cassandra on the
-server-side. This behavior can be overridden by configuring the driver to use a
+information. By default, timestamps are assigned by the driver on the
+client-side. This behavior can be overridden by configuring the driver to use a
 timestamp generator or assigning a timestamp directly to a [`CassStatement`] or
 [`CassBatch`].