Skip to content

Knockout web part disappears when running in SharePoint workbench #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 5 tasks
davros85 opened this issue Oct 12, 2016 · 4 comments
Closed
1 of 5 tasks

Knockout web part disappears when running in SharePoint workbench #234

davros85 opened this issue Oct 12, 2016 · 4 comments
Assignees
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:tracked Currently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed) type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.

Comments

@davros85
Copy link

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.

Category

  • Question
  • Typo
  • Bug
  • Enhancement / Suggestion
  • Additional article idea

Expected or Desired Behavior

When running a web part using the knockout template in the SharePoint workbench, it renders the web part.

Observed Behavior

When stepping through the code on init, the web part renders initially, below the loading spinner. Then in the _internalFirstTimeRender method, when this.context.statusRenderer.clearLoadingIndicator(this.domElement) is called, the web part disappears - it is cleaned from the DOM.

I have noticed a difference between the local workbench and SharePoint workbench - 'this.domElement' in the SP workbench contains a '.placeholder' element, whereas in the local workbench it does not.

Steps to Reproduce

Yo a new knockout webpart, (fix the _description bug, and remove all custom properties). Run the web part in the workbench in SharePoint.

@manishgarg1
Copy link

I know of this problem. Looking at fixing soon.

@manishgarg1 manishgarg1 self-assigned this Oct 12, 2016
@manishgarg1 manishgarg1 added type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. status:tracked Currently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed) area:spfx Category: SharePoint Framework (not extensions related) labels Oct 12, 2016
@davros85
Copy link
Author

Workaround presented as part of #233

@manishgarg1
Copy link

This is fixed now.

@msft-github-bot
Copy link
Collaborator

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@SharePoint SharePoint locked as resolved and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:tracked Currently tracked with Microsoft’s internal issue tracking system. DO NOT ADD/REMOVE (MSFT managed) type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Projects
None yet
Development

No branches or pull requests

3 participants