Skip to content

Commit 07ad351

Browse files
arcanisSimenB
authored andcommitted
Fixes the tests (#601)
1 parent 8e19215 commit 07ad351

File tree

5 files changed

+13
-8
lines changed

5 files changed

+13
-8
lines changed

e2e/pnp/__tests__/undeclared-dependency.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@
99
it('should surface pnp errors', () => {
1010
expect(() => {
1111
require('undeclared');
12-
}).toThrow(expect.objectContaining({code: 'UNDECLARED_DEPENDENCY'}));
12+
}).toThrow(expect.objectContaining({pnpCode: 'UNDECLARED_DEPENDENCY'}));
1313
});

packages/jest-resolve/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"@jest/types": "^26.1.0",
1414
"chalk": "^4.0.0",
1515
"graceful-fs": "^4.2.4",
16-
"jest-pnp-resolver": "^1.2.1",
16+
"jest-pnp-resolver": "^1.2.2",
1717
"jest-util": "^26.1.0",
1818
"read-pkg-up": "^7.0.1",
1919
"resolve": "^1.17.0",

packages/jest-resolve/src/defaultResolver.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import {tryRealpath} from 'jest-util';
1212
import type {Config} from '@jest/types';
1313

1414
type ResolverOptions = {
15+
allowPnp?: boolean;
1516
basedir: Config.Path;
1617
browser?: boolean;
1718
defaultResolver: typeof defaultResolver;
@@ -26,7 +27,7 @@ export default function defaultResolver(
2627
options: ResolverOptions,
2728
): Config.Path {
2829
// @ts-expect-error: the "pnp" version named isn't in DefinitelyTyped
29-
if (process.versions.pnp) {
30+
if (process.versions.pnp && options.allowPnp !== false) {
3031
return pnpResolver(path, options);
3132
}
3233

scripts/verifyOldTs.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ const cwd = tempy.directory();
3333
const tsVersion = '3.8';
3434

3535
try {
36+
fs.writeFileSync(
37+
path.join(cwd, '.yarnrc.yml'),
38+
'nodeLinker: node-modules\n',
39+
);
3640
execa.sync('yarn', ['init', '--yes'], {cwd, stdio: 'inherit'});
3741
execa.sync('yarn', ['add', `typescript@~${tsVersion}`], {
3842
cwd,

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11378,15 +11378,15 @@ fsevents@^1.2.7:
1137811378
languageName: unknown
1137911379
linkType: soft
1138011380

11381-
"jest-pnp-resolver@npm:^1.2.1":
11382-
version: 1.2.1
11383-
resolution: "jest-pnp-resolver@npm:1.2.1"
11381+
"jest-pnp-resolver@npm:^1.2.2":
11382+
version: 1.2.2
11383+
resolution: "jest-pnp-resolver@npm:1.2.2"
1138411384
peerDependencies:
1138511385
jest-resolve: "*"
1138611386
peerDependenciesMeta:
1138711387
jest-resolve:
1138811388
optional: true
11389-
checksum: ab48e45c3985a8ea89dceba6c7867017addb38a6da6121211fb533000207c56e4de1a662c3d5715524e7e3b25faaeaf242c5749a1257aecbd2d9343cbc2ddf04
11389+
checksum: d91c86e3899f35ac1a6d40fa29e94212fc9b8e5e70d31d77ff281413441c844ec44a3673a3860f9b2155fed6738548f52eee9e63845e8d5f8550a890533c78cc
1139011390
languageName: node
1139111391
linkType: hard
1139211392

@@ -11446,7 +11446,7 @@ fsevents@^1.2.7:
1144611446
chalk: ^4.0.0
1144711447
graceful-fs: ^4.2.4
1144811448
jest-haste-map: ^26.1.0
11449-
jest-pnp-resolver: ^1.2.1
11449+
jest-pnp-resolver: ^1.2.2
1145011450
jest-util: ^26.1.0
1145111451
read-pkg-up: ^7.0.1
1145211452
resolve: ^1.17.0

0 commit comments

Comments
 (0)